From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 86ED43858C78 for ; Mon, 22 Apr 2024 09:51:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86ED43858C78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86ED43858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713779467; cv=none; b=E12/uo6DM0OyQNyhr1ey7RvnPIrkYgFXAL30ozfAibG1DiumnmDSKlcIBcmOFfX1p333/hOP+EHf2LG4mGb270ygCTuI4/8e4C4BfOHZcflAxe7SRUgUHiiKoCbE5zqy9DkK5IYfMv23zhXIy9pSHY9uLyGo3+kwwC2bJx8bL5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713779467; c=relaxed/simple; bh=pP2TjlGlxaKVV0YUNfpJAIK379JFQQ4uGJSVhkM63Hk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cTFdGDL6Nvw8zLATUvldmJ0Eys8HKmY6U/NKpWkgRSsU2O7jxGyzjp9itANd72GJNnUYXPSPbQzNMBo+e36lTGltB/UUvOM6jqLFRSvmjYzdxO6VCNIAs6GJ0C0UXS0h4n/JmABOwttXcJZrYmj3EoDn7TmVvtqsAhR0IyrPsm4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1e4c4fb6af3so27371985ad.0 for ; Mon, 22 Apr 2024 02:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713779463; x=1714384263; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lW0avwa61bjv3ShenPDvouI6wiXe8qT7z+EixLkikB8=; b=H+HRTwTpiv5WI/JgeF40nDYSPmkNKhr0nZZRfn3iwFkscymIGwJtECUpM+iSGBUt0e BL3nBl7i5+o0xJ/haWjk0NpvHZwasUHORB8cYqhJrCCli6w4zkbeIumvJobcjzGHRcTd +525aEouEOZhoiRTueyX46tj86TaNAcNqSdD/j9NNcyx/oPWciLHlJ3xaXdIUH2eSC3I +sH8tgSu9XhnzKz4uCpzdNAZjNbA/2qCeqhq6QGrKZReOSAElCVgaINctLg4FJ8gAbK+ uj+2xkSOLyoX0Ziw+9+fe060ReJmYQ20mTKXEy9hpNrJLVjPipitdVKLHacADays50xj oDeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713779463; x=1714384263; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lW0avwa61bjv3ShenPDvouI6wiXe8qT7z+EixLkikB8=; b=mjEGKhRRRr/hD5NRmPtMSVp1grr+3cNNhvraCcHP80s8v7pHWngOkvFORFFLrW9sOU KbH0/bu91MKSxcv/J1xPDaM/WBA/em6sXHHPNT4RkBr7kUJsyU7eKFNaF5DRUNhgU1Sb JZvK6n+5GUaE00zmTV/F88MEhoHDVyFllLDJr4zziC+AOD6mRTF9PYQF23gBKt+FvuTY 3RsPWKLB7VoMckWcv1qYnweVfbfQ4ZzO8/RtazVqV1FqDlzH68txjAnG+GKBoTekoiYN A5ygVCbip3eNjDH42QpHebBc4GWhutlBrEK1y8mTR/DYxT3bNxpJTMQggJupccxrwxio pzEg== X-Gm-Message-State: AOJu0YyjY9q+vdmYFOaj6RmTPSxFh6igZzn+QfnkDLa7jgnHxEY01Uf5 1E7Ctd+vFWYVTmoHONCSfoASkIirdUZlUPmHLguZHRPe7gS1zvgSZL4UQJdWyA== X-Google-Smtp-Source: AGHT+IHe0XnyUKKU2hkqhG1GOyZo/bXcrB5Khanxb6FozKsca06gpyv1OJBZbRWQ8HZzHf8MjqNJRw== X-Received: by 2002:a17:902:ea12:b0:1e3:e6cb:a07f with SMTP id s18-20020a170902ea1200b001e3e6cba07fmr13100758plg.26.1713779463239; Mon, 22 Apr 2024 02:51:03 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id z21-20020a1709028f9500b001dda32430b3sm7718358plo.89.2024.04.22.02.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 02:51:02 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43M9on4H020297 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Apr 2024 06:50:49 -0300 From: Alexandre Oliva To: Hans-Peter Nilsson Cc: gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump Subject: Re: enable sqrt insns for cdce3.c Organization: Free thinker, does not speak for AdaCore References: Date: Mon, 22 Apr 2024 06:50:49 -0300 In-Reply-To: (Hans-Peter Nilsson's message of "Wed, 10 Mar 2021 12:11:34 -0500 (EST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [Revamped version of this patch, combined with others, to follow] On Mar 10, 2021, Hans-Peter Nilsson wrote: > On Wed, 10 Mar 2021, Alexandre Oliva wrote: >> >> The test expects shrink-wrapping of the fsqrt call, but that will only >> occur when there is a usable sqrt insn. >> >> Arrange for dejagnu to add the options that enable the sqrt insn, if >> one is available, and to skip the test otherwise. >> >> >> H-P, this *should* obviate the mmix-specific dg-skip-if. > Unfortunately it doesn't. >> Would it be >> easy for you to confirm that this is the case and, if so, drop it? > About as easy as for anyone (this is a compile-test), but no > problem. Unfortunately I get, with your patch applied and the > dg-skip-if removed: > FAIL: gcc.dg/cdce3.c scan-tree-dump cdce "cdce3.c:12: [^\n\r]* > function call is shrink-wrapped into error conditions." Is mmix a sqrt_insn effective target? proc check_effective_target_sqrt_insn in gcc/testsuite/lib/target-supports.exp suggests it shouldn't pass, so I'm surprised it would still try to run the test despite the added /* { dg-require-effective-target sqrt_insn } */ directive. > The dump files and assembly file show no obvious clues to me as > to what is supposed to happen; attached. cdce3 is supposed to shrink-wrap the sqrtf(x) call into something like (x >= 0 ? .SQRT(x) : sqrtf(x)), where .SQRT stands for a square root instruction. Since we don't know why it still runs for you, I'm keeping the mmix explicit skip in the new version of the patch. Thanks, -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive