public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@adacore.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: introduce overridable clear_cache emitter
Date: Thu, 10 Dec 2020 05:47:23 -0300	[thread overview]
Message-ID: <ortusu59pg.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <20201205211959.GH3788@tucnak> (Jakub Jelinek's message of "Sat,  5 Dec 2020 22:19:59 +0100")

On Dec  5, 2020, Jakub Jelinek <jakub@redhat.com> wrote:

> On Sat, Dec 05, 2020 at 06:01:59PM -0300, Alexandre Oliva wrote:
>> On Dec  5, 2020, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> 
>> > ../../../../libffi/src/aarch64/ffi.c: In function 'ffi_prep_closure_loc':
>> > ../../../../libffi/src/aarch64/ffi.c:67:3: internal compiler error: in emit_library_call_value_1, at calls.c:5300
>> >    67 |   __builtin___clear_cache (start, end);
>> >       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> 
>> Is this still aarch64-linux-gnu -mabi=ilp32?  I'm afraid I couldn't
>> duplicate this error using a cross compiler (without binutils, but with
>> HAVE_AS_MABI_OPTION forced enabled), and many variants of a manually
>> minimized ffi.c (to build without libc):

> See PR98147, I've put there an untested patch, but I have no way to test it.

Thanks for the fix.  I can't imagine why that wouldn't have been hit in
my reduced-build scenario, but once I saw your patch, it was pretty
obvious that that was it, and I haven't investigated any further.

-- 
Alexandre Oliva, happy hacker  https://FSFLA.org/blogs/lxo/
   Free Software Activist         GNU Toolchain Engineer
        Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

  reply	other threads:[~2020-12-10  8:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  2:35 Alexandre Oliva
2020-11-16 18:20 ` Olivier Hainque
2020-12-02 18:23 ` Jeff Law
2020-12-03 10:38   ` Christophe Lyon
2020-12-03 10:59     ` Alexandre Oliva
2020-12-03 14:08     ` Alexandre Oliva
2020-12-03 16:46       ` Jeff Law
2020-12-05 10:19       ` Andreas Schwab
2020-12-05 21:01         ` Alexandre Oliva
2020-12-05 21:19           ` Jakub Jelinek
2020-12-10  8:47             ` Alexandre Oliva [this message]
2020-12-10 10:58       ` Alexandre Oliva
2020-12-13 16:53         ` Jeff Law
2020-12-03 12:28 ` Andreas Schwab
2020-12-03 12:43   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ortusu59pg.fsf@lxoliva.fsfla.org \
    --to=oliva@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).