From: Alexandre Oliva <aoliva@redhat.com>
To: Bernd Schmidt <bernds@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: introduce --param max-vartrack-expr-depth
Date: Wed, 01 Jun 2011 22:29:00 -0000 [thread overview]
Message-ID: <ortyc9w5ng.fsf@livre.localdomain> (raw)
In-Reply-To: <oraae1xqpx.fsf@livre.localdomain> (Alexandre Oliva's message of "Wed, 01 Jun 2011 17:05:14 -0300")
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Jun 1, 2011, Alexandre Oliva <aoliva@redhat.com> wrote:
> On May 31, 2011, Alexandre Oliva <aoliva@redhat.com> wrote:
>> On May 30, 2011, Bernd Schmidt <bernds@codesourcery.com> wrote:
>>> On 05/30/2011 12:35 PM, Alexandre Oliva wrote:
>>>> One of my patches for PR 48866 regressed guality/asm-1.c on
>>>> x86_64-linux-gnu because what used to be a single complex debug value
>>>> expression became a chain of debug temps holding simpler expressions,
>>>> and this chain exceeded the default recursion depth in resolving
>>>> location expressions.
>>> What's the worst that can happen if you remove the limit altogether?
>> Exponential behavior comes to mind.
> It's unusual, but debug/pr41264-1.c exhibits it, given INT_MAX for the
> param, even though under such a (lack of) limit bootstrap doesn't go
> slower or faster, after restoring depth 5 for the reverse_op() use. As
> Jakub pointed out, that one probably shouldn't be affected by the
> parameter, as depth 5 is exactly what we want for the kind of expression
> we're looking for. With unlimited depth for that one, not even
> libiberty/md5.c compiles successfully, exhausting memory on a box with
> some 40GB of total VM (8+32).
> So I guess I'll stick with what I checked in, but keep a patch handy to
> bump the limit a little bit up and revert to 5 in reverse_op.
Such as this one...
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: vta-param-vartrack-expr-depth-int-max.patch --]
[-- Type: text/x-diff, Size: 1086 bytes --]
Index: gcc/params.def
===================================================================
--- gcc/params.def.orig 2011-05-31 18:28:05.348070586 -0300
+++ gcc/params.def 2011-06-01 17:09:41.117140944 -0300
@@ -845,7 +845,7 @@ DEFPARAM (PARAM_MAX_VARTRACK_SIZE,
DEFPARAM (PARAM_MAX_VARTRACK_EXPR_DEPTH,
"max-vartrack-expr-depth",
"Max. recursion depth for expanding var tracking expressions",
- 10, 0, 0)
+ 20, 0, 0)
/* Set minimum insn uid for non-debug insns. */
Index: gcc/var-tracking.c
===================================================================
--- gcc/var-tracking.c.orig 2011-05-31 20:06:25.604477956 -0300
+++ gcc/var-tracking.c 2011-05-31 23:56:06.578450957 -0300
@@ -5288,7 +5288,7 @@ reverse_op (rtx val, const_rtx expr)
arg = XEXP (src, 1);
if (!CONST_INT_P (arg) && GET_CODE (arg) != SYMBOL_REF)
{
- arg = cselib_expand_value_rtx (arg, scratch_regs, EXPR_DEPTH);
+ arg = cselib_expand_value_rtx (arg, scratch_regs, 5);
if (arg == NULL_RTX)
return NULL_RTX;
if (!CONST_INT_P (arg) && GET_CODE (arg) != SYMBOL_REF)
[-- Attachment #3: Type: text/plain, Size: 258 bytes --]
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer
next prev parent reply other threads:[~2011-06-01 22:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 12:24 Alexandre Oliva
2011-05-30 12:30 ` Jakub Jelinek
2011-05-30 12:39 ` Bernd Schmidt
2011-05-31 17:47 ` Alexandre Oliva
2011-05-31 18:16 ` Jakub Jelinek
2011-06-01 20:09 ` Alexandre Oliva
2011-06-01 22:29 ` Alexandre Oliva [this message]
2011-06-02 8:47 ` Jakub Jelinek
2011-06-02 10:07 ` Bernd Schmidt
2011-06-03 1:42 ` Alexandre Oliva
2011-07-20 20:48 ` Michael Eager
2011-07-20 20:55 ` Jakub Jelinek
2011-07-20 21:00 ` Michael Eager
2011-07-20 21:04 ` Jakub Jelinek
2011-07-21 0:10 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ortyc9w5ng.fsf@livre.localdomain \
--to=aoliva@redhat.com \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).