From: Alexandre Oliva <aoliva@redhat.com>
To: "Nicola Pero" <nicola.pero@meta-innovation.com>
Cc: "Mike Stump" <mikestump@comcast.net>,
"gcc-patches\@gnu.org" <gcc-patches@gnu.org>
Subject: Re: (build) Patch to fix cp/cfns.gperf building issues
Date: Fri, 29 Apr 2011 08:26:00 -0000 [thread overview]
Message-ID: <ortydhobr5.fsf@livre.localdomain> (raw)
In-Reply-To: <1303558468.699813970@www2.webmail.us> (Nicola Pero's message of "Sat, 23 Apr 2011 13:34:28 +0200 (CEST)")
On Apr 23, 2011, "Nicola Pero" <nicola.pero@meta-innovation.com> wrote:
> Ok to commit ?
Yeah, thanks.
> Index: ChangeLog
> +2011-04-22 Nicola Pero <nicola.pero@meta-innovation.com>
> +
> + * Makefile.in (ENABLE_MAINTAINER_RULES): New.
> +
> Index: cp/ChangeLog
> +2011-04-23 Nicola Pero <nicola.pero@meta-innovation.com>,
> + Mike Stump <mikestump@comcast.net>
> +
> + * Make-lang.in ($(srcdir)/cp/cfns.h): Enable the dependency only
> + in maintainer mode. Use the --output-file option of gperf instead
> + of > to prevent creating an empty cp/cfns.h when gperf is not
> + available.
> +
-pedantic review: how about outputting to a temporary file (say
cp/cfns.hT) and only renaming to the intended name on success, so that,
if gperf crashes or we reboot part-way through it, we don't end up with
a partially-generated file that will seem to be up to date?
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer
next prev parent reply other threads:[~2011-04-29 5:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 15:22 Nicola Pero
2011-04-22 18:04 ` Joseph S. Myers
2011-04-22 23:00 ` Nicola Pero
2011-04-23 0:10 ` Mike Stump
2011-04-23 17:55 ` Nicola Pero
2011-04-23 19:58 ` Mike Stump
2011-04-29 8:26 ` Alexandre Oliva [this message]
2011-04-29 20:37 ` Nicola Pero
2011-04-27 14:50 ` Mike Stump
2011-04-28 13:31 ` Nicola Pero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ortydhobr5.fsf@livre.localdomain \
--to=aoliva@redhat.com \
--cc=gcc-patches@gnu.org \
--cc=mikestump@comcast.net \
--cc=nicola.pero@meta-innovation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).