From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3E7683858C53 for ; Fri, 1 Mar 2024 04:54:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E7683858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E7683858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709268871; cv=none; b=nmyM7jhlPxrkkT18as86O/SqvQAh3oUb2F9ViBKe+6MDk9V3k8K+wTXN1ewIbmgszdrFzWGer6vwA0OUGMJKTvXvi8j9ijKZVzzeIprPATVS/dcFgpEW7GOI3t3Agq1NgrNljDIXTMQK0FcXv/80qYHilDGhmJfbhOcr5Xtw+dM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709268871; c=relaxed/simple; bh=2CgLy1OZy3Vh3wyQurnnQChAHOK8whuk/P7sLRqlbZQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=pDRi6hqojbFqpAU95UGt08725BbpfUXKnlQQy7U8oBQEkRailYCG0puFbFAK76IlHh1xB4WpST51V7AngQYdPDENdxUzZefiLZn5Wn8tlUHSecmnNJVvvoJZgKjsIrCsVv6R7bEJIXBp+tMULotMNyejU42Wqhg8kl716R1b8KU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from linux-libre.fsfla.org ([2001:470:142:5::54] helo=free.home) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfuug-00063q-1N; Thu, 29 Feb 2024 23:54:26 -0500 Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 4214rsNY243423 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 1 Mar 2024 01:53:56 -0300 From: Alexandre Oliva To: Richard Earnshaw Cc: Jakub Jelinek , "Joseph S. Myers" , Richard Biener , Jeff Law , gcc-patches@gcc.gnu.org, =?utf-8?Q?Torbj=C3=B6?= =?utf-8?Q?rn?= SVENSSON , Matthew Malcomson Subject: Re: [PATCH] calls: Fix up TYPE_NO_NAMED_ARGS_STDARG_P handling [PR107453] Organization: Free thinker, not speaking for the GNU Project References: <45ac2d54-21df-486c-a085-0a6c1f37a323@arm.com> Date: Fri, 01 Mar 2024 01:53:54 -0300 In-Reply-To: <45ac2d54-21df-486c-a085-0a6c1f37a323@arm.com> (Richard Earnshaw's message of "Tue, 27 Feb 2024 16:41:32 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 27, 2024, Richard Earnshaw wrote: > This one has been festering for a while; both Alexandre and Torbjorn > have attempted to fix it recently, but I'm not sure either is really > right... *nod* xref https://gcc.gnu.org/pipermail/gcc-patches/2024-March/646926.html The patch I proposed was indeed far too limited in scope. > On Arm this is causing all anonymous arguments to be passed on the > stack, which is incorrect per the ABI. On a target that uses > 'pretend_outgoing_vararg_named', why is it correct to set n_named_args > to zero? Is it enough to guard both the statements you've added with > !targetm.calls.pretend_outgoing_args_named? ISTM that the change you suggest over Jakub's patch would address the inconsistency on ARM. Matthew suggested a patch along these lines in the other thread, that I xrefed above, that seems sound to me, but I also suspect it won't fix the ppc64le issue. My hunch is that we'll need a combination of both, possibly with further tweaks to adjust for Jakub's just-added test. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Think Assange & Stallman. The empires strike back