From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTPS id 3D4DE385841A for ; Fri, 2 Dec 2022 06:36:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D4DE385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 18CFB116B04; Fri, 2 Dec 2022 01:36:46 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id B1uB9k+BZjgQ; Fri, 2 Dec 2022 01:36:46 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id AEB25116B03; Fri, 2 Dec 2022 01:36:45 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 2B26aZkc1287713 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 2 Dec 2022 03:36:36 -0300 From: Alexandre Oliva To: Jason Merrill Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH RFA] driver: fix validate_switches logic Organization: Free thinker, does not speak for AdaCore References: <20221201165051.51853-1-jason@redhat.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Fri, 02 Dec 2022 03:36:35 -0300 In-Reply-To: <20221201165051.51853-1-jason@redhat.com> (Jason Merrill's message of "Thu, 1 Dec 2022 11:50:51 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Dec 1, 2022, Jason Merrill wrote: > Once we see g*, starred is set. Then we see %:, and it sees that as a > zero-length switch, which because starred is still set, matches any and all > command-line options. So targets that use such a spec accept all options in > the driver, while ones that don't reject some, such as the recent > -nostdlib++. Woo, nice catch, thanks! I don't have authority to approve the patch, but it's ok as far as I'm concerned. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about