* add powerpc_vsx_ok requirement to undef-bool tests
@ 2021-02-26 16:14 Alexandre Oliva
2021-02-26 17:32 ` David Edelsohn
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Oliva @ 2021-02-26 16:14 UTC (permalink / raw)
To: gcc-patches
Cc: Joel Brobecker, David Edelsohn, Segher Boessenkool, Rainer Orth,
Mike Stump
These tests use -mvsx in their dg-options list, so they are only
applicable if the -mvsx option is supported by the compiler.
Tested with target ppc64-vx7r2, configured to force altivec disabled,
and thus to reject vsx. Ok to install?
From: Joel Brobecker <brobecker@adacore.com>
gcc/testsuite/ChangeLog:
* gcc.target/powerpc/undef-bool-2.c: Add
dg-require-effective-target powerpc_vsx_ok directive.
* g++.dg/ext/undef-bool-1.C: Add dg-require-effective-target
powerpc_vsx_ok directive.
---
gcc/testsuite/g++.dg/ext/undef-bool-1.C | 1 +
gcc/testsuite/gcc.target/powerpc/undef-bool-2.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/gcc/testsuite/g++.dg/ext/undef-bool-1.C b/gcc/testsuite/g++.dg/ext/undef-bool-1.C
index 716e06c1ce413..9cc1cd8726098 100644
--- a/gcc/testsuite/g++.dg/ext/undef-bool-1.C
+++ b/gcc/testsuite/g++.dg/ext/undef-bool-1.C
@@ -1,6 +1,7 @@
/* { dg-do compile { target { powerpc*-*-* } } } */
/* { dg-options "-O2 -DNO_WARN_X86_INTRINSICS -mvsx" } */
/* { dg-require-effective-target lp64 } */
+/* { dg-require-effective-target powerpc_vsx_ok } */
/* Test to ensure that "bool" gets undef'd in xmmintrin.h when
we require strict ANSI. */
diff --git a/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c b/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
index d4944ab1ca6c7..7bc5d18484039 100644
--- a/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
+++ b/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
@@ -1,6 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -std=c11 -DNO_WARN_X86_INTRINSICS -mvsx" } */
/* { dg-require-effective-target lp64 } */
+/* { dg-require-effective-target powerpc_vsx_ok } */
/* Test to ensure that "bool" gets undef'd in xmmintrin.h when
we require strict ANSI. Subsequent use of bool needs stdbool.h.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add powerpc_vsx_ok requirement to undef-bool tests
2021-02-26 16:14 add powerpc_vsx_ok requirement to undef-bool tests Alexandre Oliva
@ 2021-02-26 17:32 ` David Edelsohn
2021-03-09 3:18 ` Alexandre Oliva
0 siblings, 1 reply; 3+ messages in thread
From: David Edelsohn @ 2021-02-26 17:32 UTC (permalink / raw)
To: Alexandre Oliva
Cc: GCC Patches, Joel Brobecker, Segher Boessenkool, Rainer Orth, Mike Stump
On Fri, Feb 26, 2021 at 11:14 AM Alexandre Oliva <oliva@adacore.com> wrote:
>
> These tests use -mvsx in their dg-options list, so they are only
> applicable if the -mvsx option is supported by the compiler.
>
> Tested with target ppc64-vx7r2, configured to force altivec disabled,
> and thus to reject vsx. Ok to install?
This patch is okay.
Thanks, David
>
>
> From: Joel Brobecker <brobecker@adacore.com>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/powerpc/undef-bool-2.c: Add
> dg-require-effective-target powerpc_vsx_ok directive.
> * g++.dg/ext/undef-bool-1.C: Add dg-require-effective-target
> powerpc_vsx_ok directive.
> ---
> gcc/testsuite/g++.dg/ext/undef-bool-1.C | 1 +
> gcc/testsuite/gcc.target/powerpc/undef-bool-2.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/g++.dg/ext/undef-bool-1.C b/gcc/testsuite/g++.dg/ext/undef-bool-1.C
> index 716e06c1ce413..9cc1cd8726098 100644
> --- a/gcc/testsuite/g++.dg/ext/undef-bool-1.C
> +++ b/gcc/testsuite/g++.dg/ext/undef-bool-1.C
> @@ -1,6 +1,7 @@
> /* { dg-do compile { target { powerpc*-*-* } } } */
> /* { dg-options "-O2 -DNO_WARN_X86_INTRINSICS -mvsx" } */
> /* { dg-require-effective-target lp64 } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
>
> /* Test to ensure that "bool" gets undef'd in xmmintrin.h when
> we require strict ANSI. */
> diff --git a/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c b/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
> index d4944ab1ca6c7..7bc5d18484039 100644
> --- a/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
> +++ b/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
> @@ -1,6 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -std=c11 -DNO_WARN_X86_INTRINSICS -mvsx" } */
> /* { dg-require-effective-target lp64 } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
>
> /* Test to ensure that "bool" gets undef'd in xmmintrin.h when
> we require strict ANSI. Subsequent use of bool needs stdbool.h.
>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add powerpc_vsx_ok requirement to undef-bool tests
2021-02-26 17:32 ` David Edelsohn
@ 2021-03-09 3:18 ` Alexandre Oliva
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2021-03-09 3:18 UTC (permalink / raw)
To: David Edelsohn
Cc: GCC Patches, Joel Brobecker, Segher Boessenkool, Rainer Orth, Mike Stump
On Feb 26, 2021, David Edelsohn <dje.gcc@gmail.com> wrote:
> This patch is okay.
Thanks, I've finally checked it in.
>> From: Joel Brobecker <brobecker@adacore.com>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/powerpc/undef-bool-2.c: Add
>> dg-require-effective-target powerpc_vsx_ok directive.
>> * g++.dg/ext/undef-bool-1.C: Add dg-require-effective-target
>> powerpc_vsx_ok directive.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-09 3:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 16:14 add powerpc_vsx_ok requirement to undef-bool tests Alexandre Oliva
2021-02-26 17:32 ` David Edelsohn
2021-03-09 3:18 ` Alexandre Oliva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).