From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2278 invoked by alias); 13 Apr 2012 16:01:07 -0000 Received: (qmail 2242 invoked by uid 22791); 13 Apr 2012 16:01:01 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD,T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 16:00:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3DG0m45023263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Apr 2012 12:00:48 -0400 Received: from freie.oliva.athome.lsd.ic.unicamp.br (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3DG0kMp031558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 13 Apr 2012 12:00:48 -0400 Received: from livre.localdomain (livre-to-gw.oliva.athome.lsd.ic.unicamp.br [172.31.160.19]) by freie.oliva.athome.lsd.ic.unicamp.br (8.14.5/8.14.5) with ESMTP id q3DG0kBk005546 for ; Fri, 13 Apr 2012 13:00:46 -0300 Received: from livre.localdomain (aoliva@localhost.localdomain [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q3DG0js1019540; Fri, 13 Apr 2012 13:00:45 -0300 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id q3DG0jhU019539; Fri, 13 Apr 2012 13:00:45 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Subject: Re: fix incorrect debug temp added by df-problems References: Date: Fri, 13 Apr 2012 16:01:00 -0000 In-Reply-To: (Alexandre Oliva's message of "Mon, 09 Apr 2012 03:44:47 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg00852.txt.bz2 --=-=-= Content-length: 403 On Apr 9, 2012, Jakub Jelinek wrote, in response to my posting to the wrong thread (now fixed): > On Mon, Apr 09, 2012 at 03:29:05AM -0300, Alexandre Oliva wrote: >> + && (!df_ignore_stack_reg (uregno))) > Please remove the extra () around this line, > && !df_ignore_stack_reg (uregno)) > Ok for trunk with that change, thanks. Thanks, here's what I've just installed. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=df-probs-no-death-of-artif-uses.patch Content-length: 907 This fixes a bug in pr43165.c with -Os -g. for gcc/ChangeLog from Alexandre Oliva * df-problems.c (df_note_bb_compute): Do not take note of debug uses for whose REGs we won't emit DEAD or UNUSED notes. Index: gcc/df-problems.c =================================================================== --- gcc/df-problems.c.orig 2012-04-13 05:18:28.604788011 -0300 +++ gcc/df-problems.c 2012-04-13 06:58:42.053258184 -0300 @@ -3453,7 +3453,12 @@ df_note_bb_compute (unsigned int bb_inde { if (debug_insn > 0) { - dead_debug_add (&debug, use, uregno); + /* We won't add REG_UNUSED or REG_DEAD notes for + these, so we don't have to mess with them in + debug insns either. */ + if (!bitmap_bit_p (artificial_uses, uregno) + && !df_ignore_stack_reg (uregno)) + dead_debug_add (&debug, use, uregno); continue; } break; --=-=-= Content-length: 257 -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer --=-=-=--