From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id F1F59385E838 for ; Fri, 24 May 2024 11:34:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1F59385E838 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1F59385E838 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::634 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716550477; cv=none; b=ZFoW16LWVhgaIw3LNJVIwOSs4yVpFqKJv/TPfrOlf+S8cVCI5Wf9Ytt1Oa6gKGLBEgSmZK92hkX3lskZJuyWIg814Qi7oeB4kJ4aREj/c3xX0xWiurMsTWz7wVdpXLNNfErMEhp8IX59MGTGdEiJt4wUenFhPjpe/WBHp16HWVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716550477; c=relaxed/simple; bh=4y3tCtuIfnyq7jSx+5lGK/CxB9D15dQsoe1jQpwvGtw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XxemsahHZqHBE4lgo0Ev5fSXp4Y0VBTG+JlqVPRwQWctQFFxmtE+KZltH9yNm/DD2yPVvrbjzYwJvMhXWcleVAA/OU6R36jW/YGv3AEII1fNQRhwk/1y77gQjXmvKF0Jj+1cbwI4UvMEgaAYm7tp6WpRyR3rtyYs2+XSadQQq5I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1f44b5b9de6so5347825ad.3 for ; Fri, 24 May 2024 04:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1716550474; x=1717155274; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+xvHHEsnc4NdAWQ6MM86GvaClPFAndYkEnjebjMrqag=; b=SRs/ucUxavCMeLnQ3e0ldgM3O6waHm5cmDqR3UCRxaI/BD7/RNcorIZ59cjLuVJnSQ hVE1DlZ8tPlh+98ND1Y6ryQl1+P4t9oGUZGBYoK+uA199fl2SqNImRL6O5UuDCrpKRG0 1LHd/oqWbCVmGlVBRK0MDtRKticJf3V3RQ579bpjoOzar6O+rjs+mx6lKQzf/LODnDij ePiq7Js9uvlapSOa0BnvE8mccFuZa8V0i8xsEhsR4O1rXqIYj1QRLuy6UKVEzS+xKOFO NsLtQdtP/1S5O1XR3tYt7kQckiNILMkCfI1MzsQ7kknkTMXKeh1bN1Wm6HIH2mLjqNOC jdwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716550474; x=1717155274; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+xvHHEsnc4NdAWQ6MM86GvaClPFAndYkEnjebjMrqag=; b=YWmIb9+ZYFVDGUBpcL0OZwDX3hDNDIsmccSGu9qqKoelo5WqRgHekwgbIZJR3SLjv9 jAB9//aS5g9wLSIzIxSbs5y7KkJ9V/T6ERDMJSHJsUyhzGVsEXJmfYj7yLYSmwqNNpUZ B/DLVOl/KGkpn3we1jeu3wmyQF+G1jn/4IZNNWvmnWII/22HMUg/fku1YJS+BGohs0GF 3nGobX6WUKb8rvTETuOhb8pnhx/h1NdbfdZB0FrhXoXyT31BmK7irnWGfX/ytdbPOCtN BwlM8PN0/9hLxH3lrm+hJh+UY0Ib3JXR4UWs2cwW4EvWDDUsNB70PVPO26k05Ev2Q4h3 aoiA== X-Forwarded-Encrypted: i=1; AJvYcCW3SkiLNRAobc2kekfOMVKq5c6jyL4fknRT+ItG2EKupMSlhCoxszVhH/6K3Q4nzq8Spov3toaHsXwmtC939hjdPGLnPrQPiw== X-Gm-Message-State: AOJu0YxvD/1L/8ELzxZagrwCWzB3K8Cn71PzbdMM+94W5u2Ecd9AidiW fhm4fMDVt9Xd9Cn+I/nX7SCc251QAnP6QYWEUC50/LUAbQtWd07EtDnJgzxHEQ== X-Google-Smtp-Source: AGHT+IFYiXrY9cfLKKobvzAwmrqe86rEdNwhTHIRyWoGIAzf2SOt7BpvR5wQzl20HDWvafk9i3H+Pg== X-Received: by 2002:a17:903:41ce:b0:1f3:ccc:7cb5 with SMTP id d9443c01a7336-1f4498f4067mr22535985ad.68.1716550473705; Fri, 24 May 2024 04:34:33 -0700 (PDT) Received: from free.home ([2804:7f1:218b:1961:ef8:d680:5399:8b1a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c9684cdsm11953735ad.175.2024.05.24.04.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 04:34:33 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 44OBYFcN227117 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 24 May 2024 08:34:16 -0300 From: Alexandre Oliva To: "Kewen.Lin" Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] adjust vectorization expectations for ppc costmodel 76b Organization: Free thinker, does not speak for AdaCore References: <2e142c5c-b48e-a3a6-ddf4-10fd53a47233@linux.ibm.com> <1ea56d29-4845-e364-e39b-f2f51afc0bbb@linux.ibm.com> Date: Fri, 24 May 2024 08:34:15 -0300 In-Reply-To: (Alexandre Oliva's message of "Thu, 23 May 2024 10:22:32 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On May 23, 2024, Alexandre Oliva wrote: > On Apr 29, 2024, "Kewen.Lin" wrote: >> I think you can still push the patch as the testing just exposes >> another issue. > ACK, thanks, I've just confirmed that the problem I reported on > ppc64el-linux-gnu didn't come up when testing on ppc64-vx7r2 with a > non-power8 emulated cpu, so I'm going to install it. I see I hadn't posted the latest version of the patch, with the updated attribution and commit message. Here it is. I'm checking it in. testsuite: adjust iteration count for ppc costmodel 76b From: Alexandre Oliva For some hardware which doesn't support unaligned vector memory access, test case costmodel-vect-76b.c expects to see cost modeling would make the decision that it's not profitable for peeling, according to the commit history, test case comments and the way to check. For now, the existing loop bound 14 works well for Power7, but it does not for some targets on which the cost of operation vec_perm can be different from Power7, such as: Power6, it's 3 vs. 1. This difference further causes the difference (10 vs. 12) on the minimum iteration for profitability and cause the failure. To keep the original test point, this patch is to tweak the loop bound to ensure it's not profitable to be vectorized for !vect_no_align with peeling. Co-Authored-By: Kewen Lin for gcc/testsuite/ChangeLog * gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c (N): Tweak. --- .../gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c index cbbfbb24658f8..e48b0ab759e75 100644 --- a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c +++ b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c @@ -6,7 +6,7 @@ /* On Power7 without misalign vector support, this case is to check it's not profitable to perform vectorization by peeling to align the store. */ -#define N 14 +#define N 13 #define OFF 4 /* Check handling of accesses for which the "initial condition" - -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive