From: Alexandre Oliva <oliva@adacore.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [tree-prof] skip if errors were seen [PR113681]
Date: Fri, 29 Mar 2024 16:38:08 -0300 [thread overview]
Message-ID: <orwmpkkevz.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <2eb2c361-b0d6-4d5f-989a-305d135c298b@gmail.com> (Jeff Law's message of "Fri, 22 Mar 2024 12:10:41 -0600")
On Mar 22, 2024, Jeff Law <jeffreyalaw@gmail.com> wrote:
> On 3/9/24 2:11 AM, Alexandre Oliva wrote:
>> ipa_tree_profile asserts that the symtab is in IPA_SSA state, but we
>> don't reach that state and ICE if e.g. ipa-strub passes report errors.
>> Skip this pass if errors were seen.
>> Regstrapped on x86_64-linux-gnu. Ok to install?
>>
>> for gcc/ChangeLog
>> PR tree-optimization/113681
>> * tree-profiling.cc (pass_ipa_tree_profile::gate): Skip if
>> seen_errors.
>> for gcc/testsuite/ChangeLog
>> PR tree-optimization/113681
>> * c-c++-common/strub-pr113681.c: New.
> So I've really never dug into strub, but this would seem to imply that
> an error from strub is non-fatal?
Yeah. I believe that's no different from other passes.
Various other passes have seen_errors guards, but ipa-prof didn't.
I suppose the insertion point for the strubm pass was one where others
passes didn't previously issue errors, so that wasn't an issue for
ipa-prof. But now it is.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
next prev parent reply other threads:[~2024-03-29 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 9:11 Alexandre Oliva
2024-03-22 18:10 ` Jeff Law
2024-03-29 19:38 ` Alexandre Oliva [this message]
2024-04-16 4:03 ` Alexandre Oliva
2024-05-25 8:22 ` Alexandre Oliva
2024-06-09 1:53 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orwmpkkevz.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).