From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 058503858CDA for ; Tue, 30 Jan 2024 03:35:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 058503858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 058503858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706585754; cv=none; b=sZA7uTif4PtuHLhx33exN2auCA3FF+1QbWafEwxaTg02zSw+d2VMrdfnNdKq0dMF1ktTGDOAdxYIVjenhQ5VkAPB9EfekrfSKm14xCrKUUKd1xRYDWvwutd6NCJdvaLzsqC/0jq0XUYrg3APBcd5TV9UAMpx82bxuFoZN6VxlLQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706585754; c=relaxed/simple; bh=CLp02QX2hDN/EHVjmqxHJvEI5hM7kOWJGrqAE+EEDk4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rUYVj7SaUH8piM+717CJG4F7TJSMAYqF4bn5PkuLC91jhJPBcWwPeuPQkvKuFHcFn1FXUEmWWK+PE8VP7cEZBb1HYGMQT3QLDWmUcBYfQeHnsBDfan2Tzqv1mteO4KqsF2ScglPpch2zWZ6c/NADW7jBiYa+Fmc7VDfMQybOGBc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3be6ff4f660so671437b6e.3 for ; Mon, 29 Jan 2024 19:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1706585750; x=1707190550; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GBf1jz9tOfj09yBap+0N1D9Wmixw1FFWTRhqFAZcN1g=; b=j2NzqmDyN3KHR67hEKNBCcwPhYgb17NpeM6a3Vp7TwPB4ceRVxI/xTwNnL7qLVLVlA CnAIVDQAbOljD7zSV8k6SXMw8oLdlJU4u7Zr+bPNrTLdBwxnDVd1pa6Ghe8a7p5oWYvr ikVfXJCcCrO2JRBDAjKAL4cORqZnQb114uSV6S5IJoijY+wOHlQ8fvhHNmYnd18h4T21 UY1fMYpQQgl+pbdbhK59KlNWLCdRuW6MZFPsB9x37pkimsxQNmUA+lr7pmBR0EcC+Ok0 SDJTSg6ZnC8G4IrxGOc1gEbbLUBlUnwLatRlnq5yqIJML6LeIVeovtHrkAKfhnxsAuon ueww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706585750; x=1707190550; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GBf1jz9tOfj09yBap+0N1D9Wmixw1FFWTRhqFAZcN1g=; b=nHZA5s2kBPCpFf/WQzouC5tsSJwSVGbYrRaSi5TWmNm1XqntqcAVbrWkywEEJevmaE 0UfcAtYRutOkHeQh9igZ+VMedkVC5NqEyGXSlpL9DVuqidOEqYlc2S1UADti/VDRFmZw odO89yFNPLu84dSFdeVomIewa5JrcZ68/TqbtsmXbgwJlG5sv0wn8cIZNLlAWUR2v2DF m5e4TNqGlLIKLc85aRMo9TahICDVfQvGhNWGZiVPaXQzHmZ32ulKo0U/bEU0iX6wXlJV EkzrPsamNmsKXHKugXu9tFy3UkAo6kvW9AFWI1P3Kk+NLXt7F2ot/0mCoks8bHeAD4Wj 4cEQ== X-Gm-Message-State: AOJu0Yx3Y+GP/NcAuif0sf+KLo25zir3HK9PwTv3xyJb4FHSI7q08/lv NWmmO/Z+VH4XJrmS/tItQJBZ3DKp7tk6HKoxmHmlQWVwWTvJiDwVbHfc7dvvFA== X-Google-Smtp-Source: AGHT+IHzxkSEIJg6nffMV8FGgZMoZCXuegrAy4+BTpoZI5NxJDWKt4y9PmmLvYKS9bdzX9nggPvJEQ== X-Received: by 2002:a05:6808:1a8c:b0:3bd:4bef:a15c with SMTP id bm12-20020a0568081a8c00b003bd4befa15cmr6801146oib.44.1706585750131; Mon, 29 Jan 2024 19:35:50 -0800 (PST) Received: from free.home ([2804:7f1:218b:d88:4bd5:3dd7:ea20:12bc]) by smtp.gmail.com with ESMTPSA id hq24-20020a056a00681800b006dbdbe7f71csm6869176pfb.98.2024.01.29.19.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 19:35:49 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 40U3ZaKj1673004 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 00:35:37 -0300 From: Alexandre Oliva To: "Kewen.Lin" Cc: David Edelsohn , GCC Patches , Richard Biener , Jakub Jelinek , Peter Bergner , Segher Boessenkool , Jeff Law , Richard Sandiford Subject: Re: [PATCH] strub: Only unbias stack point for SPARC_STACK_BOUNDARY_HACK [PR113100] Organization: Free thinker, does not speak for AdaCore References: <91d2c107-0168-791b-b5fa-de21c2345f84@linux.ibm.com> Date: Tue, 30 Jan 2024 00:35:36 -0300 In-Reply-To: (Alexandre Oliva's message of "Fri, 19 Jan 2024 03:23:32 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 19, 2024, Alexandre Oliva wrote: > On Jan 18, 2024, "Kewen.Lin" wrote: >> Not sure if I missed something in the testing, could you >> kindly double check if those test cases started to fail from r14-6275 on your >> env? > My guess is that they started to fail when David attempted to bypass the > strub tests by changing the dg proc that detects strub support. The > tests then detected the mismatch between the result of the proc and the > expected errors when strub is disabled properly. The patch below, that realigns stack scrubbing on sparc32 and sparc64, is still pending review (Ping?), but since your fix for ppc (that worsened scrubbing on sparc32) has long been in, I'm pushing the reversal of commit 9773ca519864e2e0706424b805c3314f1fbe7d10. > strub: introduce STACK_ADDRESS_OFFSET > Since STACK_POINTER_OFFSET is not necessarily at the boundary between > caller- and callee-owned stack, as desired by > __builtin_stack_address(), and using it as if it were or not causes > problems, introduce a new macro so that ports can define it suitably, > without modifying STACK_POINTER_OFFSET. > for gcc/ChangeLog > PR middle-end/112917 > PR middle-end/113100 > * builtins.cc (expand_builtin_stack_address): Use > STACK_ADDRESS_OFFSET. > * doc/extend.texi (__builtin_stack_address): Adjust. > * config/sparc/sparc.h (STACK_ADDRESS_OFFSET): Define. > * doc/tm.texi.in (STACK_ADDRESS_OFFSET): Document. > * doc/tm.texi.in: Rebuilt. Ping? https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643408.html -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive