From: Alexandre Oliva <oliva@adacore.com>
To: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: [PATCH] libstdc++: async: tolerate slightly shorter sleep
Date: Wed, 22 Jun 2022 03:03:15 -0300 [thread overview]
Message-ID: <orzgi59qvw.fsf@lxoliva.fsfla.org> (raw)
Even without frequent signals interrupting nanosleep, sleep_for on
rtems on qemu wakes up too early by a predictable margin of less than
0,3%, which some async tests complain about the too-short wait times.
Allow the tests to tolerate a little sleep deprivation.
Regstrapped on x86_64-linux-gnu, also tested with a cross to
aarch64-rtems6. Ok to install?
for libstdc++-v3/ChangeLog
* testsuite/30_threads/async/async.cc: Tolerate early wakeup.
---
libstdc++-v3/testsuite/30_threads/async/async.cc | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libstdc++-v3/testsuite/30_threads/async/async.cc b/libstdc++-v3/testsuite/30_threads/async/async.cc
index 38943ff1a9a5e..b151677af6a0e 100644
--- a/libstdc++-v3/testsuite/30_threads/async/async.cc
+++ b/libstdc++-v3/testsuite/30_threads/async/async.cc
@@ -104,7 +104,8 @@ void test03()
VERIFY( status == std::future_status::ready );
auto const elapsed = CLOCK::now() - start;
- VERIFY( elapsed >= std::chrono::seconds(2) );
+ auto const tolerance = std::chrono::milliseconds(6);
+ VERIFY( elapsed + tolerance >= std::chrono::seconds(2) );
VERIFY( elapsed < std::chrono::seconds(5) );
}
@@ -169,7 +170,8 @@ void test_pr91486_wait_for()
auto status = f1.wait_for(wait_time);
auto const elapsed_steady = chrono::steady_clock::now() - start_steady;
- VERIFY( elapsed_steady >= std::chrono::seconds(1) );
+ auto const tolerance = std::chrono::milliseconds(3);
+ VERIFY( elapsed_steady + tolerance >= std::chrono::seconds(1) );
}
// This is a clock with a very recent epoch which ensures that the difference
@@ -222,7 +224,8 @@ void test_pr91486_wait_until()
auto const elapsed_steady = chrono::steady_clock::now() - start_steady;
// This checks that we didn't come back too soon
- VERIFY( elapsed_steady >= std::chrono::seconds(1) );
+ auto const tolerance = std::chrono::milliseconds(3);
+ VERIFY( elapsed_steady + tolerance >= std::chrono::seconds(1) );
// This checks that wait_until didn't busy wait checking the clock more times
// than necessary.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next reply other threads:[~2022-06-22 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:03 Alexandre Oliva [this message]
2022-06-23 11:36 ` Alexandre Oliva
2022-10-12 11:41 ` Jonathan Wakely
2022-10-12 11:45 ` Jonathan Wakely
2022-10-12 21:11 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orzgi59qvw.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).