From: Alexandre Oliva <oliva@adacore.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org, cnsun@uwaterloo.ca
Subject: Re: [PR100843] store by mult pieces: punt on max_len < min_len
Date: Sat, 11 Dec 2021 02:18:22 -0300 [thread overview]
Message-ID: <orzgp767oh.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <00e83976-f1f2-9080-6d97-2703ed1dc7a4@gmail.com> (Jeff Law's message of "Fri, 10 Dec 2021 15:33:27 -0700")
On Dec 10, 2021, Jeff Law <jeffreyalaw@gmail.com> wrote:
> The patch is clearly safe. My question is should we have caught this
> earlier in the call chain?
Callers will call try_store_by_multiple_pieces if set_storage_via_setmem
fails. setmem doesn't necessarily need min and max len to do its job,
so if we were to modify callers, it would be just guarding the calls of
try_store_by_multiple_pieces with max_len >= min_len: 3 callers in 2
files, which didn't seem appealing to me.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2021-12-11 5:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 22:16 Alexandre Oliva
2021-12-10 22:33 ` Jeff Law
2021-12-11 5:18 ` Alexandre Oliva [this message]
2021-12-14 21:58 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orzgp767oh.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=cnsun@uwaterloo.ca \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).