From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 6FE00385782C for ; Thu, 7 Mar 2024 11:11:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FE00385782C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FE00385782C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709809893; cv=none; b=mwRHS79a0Zf5yudVrOmUNhrYa+nqxP7BlRsBJEU5s+TFcquCSMeI9IZKmAvHgoUQgD6PR1kjuExb+SlBxRpjWk9rTJPWOXg1Y8zmqPe0dcLYly/YJ59BCIu8Dpn14ctdUDBbhxblPERywdw3l+bZXj0ANtH4aXzux3i+AsMYx3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709809893; c=relaxed/simple; bh=Zd9y9K9tNw+8OBRbDYjhbFN1NTYVJi+A2S5MspoWg+8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=E51jRO/jBTMu6Nsk8si5E2QDkoDCrTvbniHyzGzApPSiU2o/wskVEZ4FBLBGXbbyNGvvwhQrGmtzVJQ4KoW7rBrCNek0A9PEN6ikdHoxiVlCU6bT2URGzzwdPYrBqyDhZl7J4ssn670YgqBMuWSr5K2n5WXuYPMtVsQo7JIqtPs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9A0FD8CA68; Thu, 7 Mar 2024 10:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709808346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=37WWaRotvc9mt0ZjKYnXK4m0EQi4uMG8/JVOemUJIsE=; b=rL57i0fgieNYOBJSB3lLGz6XZ67wv6iBX+xN5i9Vj2jNmCi/UrzEbx/gxmhZELujgObqKS 5KrV9Say1n6u1pbhbNVeYaGDNS5fSddIv+PV196cbeLhhHbCyNzVID0HHBcPiwaIPqWF0h OZRKMIfQyxWQVqqC/AZE8EPBxYe2Kfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709808346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=37WWaRotvc9mt0ZjKYnXK4m0EQi4uMG8/JVOemUJIsE=; b=YYbS7OYp45ffkXg8xsfr5IkbdzGCFL3ybUPG6SbfzRPO/692IIdyT1vhDsIYNoXD0OgPqI FN0rU/+gIuJi/CAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709808346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=37WWaRotvc9mt0ZjKYnXK4m0EQi4uMG8/JVOemUJIsE=; b=rL57i0fgieNYOBJSB3lLGz6XZ67wv6iBX+xN5i9Vj2jNmCi/UrzEbx/gxmhZELujgObqKS 5KrV9Say1n6u1pbhbNVeYaGDNS5fSddIv+PV196cbeLhhHbCyNzVID0HHBcPiwaIPqWF0h OZRKMIfQyxWQVqqC/AZE8EPBxYe2Kfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709808346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=37WWaRotvc9mt0ZjKYnXK4m0EQi4uMG8/JVOemUJIsE=; b=YYbS7OYp45ffkXg8xsfr5IkbdzGCFL3ybUPG6SbfzRPO/692IIdyT1vhDsIYNoXD0OgPqI FN0rU/+gIuJi/CAA== Date: Thu, 7 Mar 2024 11:45:45 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: Uros Bizjak , "gcc-patches@gcc.gnu.org" , Jeff Law , segher@kernel.crashing.org Subject: Re: [PATCH v2] combine: Fix ICE in try_combine on pr112494.c [PR112560] In-Reply-To: Message-ID: References: <2737spr1-459p-3oon-n852-qn034s55p66r@fhfr.qr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 1.73 X-Spamd-Result: default: False [1.73 / 50.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(2.96)[0.985]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,gcc.gnu.org,kernel.crashing.org]; BAYES_HAM(-0.13)[67.41%] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Mar 2024, Jakub Jelinek wrote: > On Thu, Mar 07, 2024 at 11:11:35AM +0100, Uros Bizjak wrote: > > > Since you CCed me - looking at the code I wonder why we fatally fail. > > > The following might also fix the issue and preserve more of the > > > rest of the flow of the function. > > > > > > If that works I'd prefer it. But I'll defer approval to the combine > > > maintainer which is Segher. > > > > Your patch is basically what v1 did [1], but it was suggested (in a > > reply by you ;) ) that we should stop the attempt to combine if we > > can't handle the use. So, the v2 patch undoes the combine and records > > a nice message in this case. > > My understanding of Richi's patch is that it it treats the non-COMPARISON_P > the same as if find_single_use fails, which is a common case that certainly > has to be handled right and it doesn't seem that we are giving up completely > for that case. So, I think it is reasonable to treat the non-COMPARISON_P > *cc_use_loc as NULL cc_use_loc. The question is, whether a NULL cc_use_loc (find_single_use returning NULL) means "there is no use" or it can mean "huh, don't know, maybe more than one, maybe I was too stupid to indentify the single use". The implementation suggests it's all broken ;) Richard.