From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rguenther@suse.de>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by sourceware.org (Postfix) with ESMTPS id 2CD79385E445
 for <gcc-patches@gcc.gnu.org>; Mon, 28 Mar 2022 07:47:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CD79385E445
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id 173121F37C;
 Mon, 28 Mar 2022 07:47:55 +0000 (UTC)
Received: from murzim.suse.de (murzim.suse.de [10.160.4.192])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 10A29A3B82;
 Mon, 28 Mar 2022 07:47:55 +0000 (UTC)
Date: Mon, 28 Mar 2022 09:47:54 +0200 (CEST)
From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] predcom: Fix up component::component [PR105056]
In-Reply-To: <Yj7SthxrXRlW3IBn@tucnak>
Message-ID: <p87rpqos-7ps6-5so8-10o1-88852q48qpo7@fhfr.qr>
References: <Yj7SthxrXRlW3IBn@tucnak>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Mar 2022 07:47:57 -0000

On Sat, 26 Mar 2022, Jakub Jelinek wrote:

> Hi!
> 
> The recent change didn't initialize comp_step while previously we used
> XCNEW to allocate it.
> 
> I think RS_ANY is better than RS_INTERNAL (== 0) as the default.
> 
> Bootstrappedd/regtested on x86_64-linux and i686-linux, ok for trunk?

OK.

> 2022-03-26  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR tree-optimization/105056
> 	* tree-predcom.cc (component::component): Initialize also comp_step.
> 
> --- gcc/tree-predcom.cc.jj	2022-03-24 12:23:11.000000000 +0100
> +++ gcc/tree-predcom.cc	2022-03-25 17:50:09.238282600 +0100
> @@ -367,7 +367,8 @@ enum ref_step_type
>  
>  struct component
>  {
> -  component (bool es) : eliminate_store_p (es), next (NULL) {}
> +  component (bool es) : comp_step (RS_ANY), eliminate_store_p (es),
> +    next (NULL) {}
>  
>    /* The references in the component.  */
>    auto_vec<dref> refs;
> 
> 	Jakub
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)