[PATCH]middle-end vect: Exclude TOP permute from blend considerations

[Tamar Christina <tamar.christina@arm.com>]

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

Hi All,

Similarly to UNKNOWN permutes, TOP needs to be excluded from being considered
for blends because it produces no permute to check.

Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu
and no issues.

Committed under the GCC obvious rules.

Thanks,
Tamar

gcc/ChangeLog:

	PR middle-end/98264
	* tree-vect-slp-patterns.c (linear_loads_p): Exclude TOP permute.

gcc/testsuite/ChangeLog:

	* gcc.target/i386/pr98264.c: New test.

--- inline copy of patch --

diff --git a/gcc/testsuite/gcc.target/i386/pr98264.c b/gcc/testsuite/gcc.target/i386/pr98264.c
new file mode 100644
index 0000000000000000000000000000000000000000..ea235277911f2a48b4b6f2ccd75a4f9000918599
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr98264.c
@@ -0,0 +1,22 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-O3 -w" } */
+
+a[], g[], h[];
+double b, c;
+double j[];
+i;
+l() {
+  int e = 0;
+  for (; e < 80; e += 4) {
+    a[0] = h[e];
+    a[1] = h[e + 1];
+    j[0] = a[0] - c;
+    j[1] = a[1] + b;
+    __attribute__(()) k = *(double *)a, e, f = e = 0;
+    *g = k;
+    double *d = j;
+    for (; e < 2; e++)
+      if (d[e])
+        i = f;
+  }
+}
diff --git a/gcc/tree-vect-slp-patterns.c b/gcc/tree-vect-slp-patterns.c
index bb2830d1d35d1607d1566868ffbcead97e4790d7..fede88923af8521ee4954c8ae27b0e589f975610 100644
--- a/gcc/tree-vect-slp-patterns.c
+++ b/gcc/tree-vect-slp-patterns.c
@@ -240,7 +240,8 @@ linear_loads_p (slp_tree_to_load_perm_map_t *perm_cache, slp_tree root)
     {
       complex_load_perm_t res = linear_loads_p (perm_cache, child);
       kind = vect_merge_perms (kind, res.first);
-      if (kind == PERM_UNKNOWN)
+      /* Unknown and Top are not valid on blends as they produce no permute.  */
+      if (kind == PERM_UNKNOWN || kind == PERM_TOP)
 	return retval;
       all_loads.safe_push (res.second);
     }


-- 

[-- Attachment #2: rb13912.patch --]
[-- Type: text/x-diff, Size: 1375 bytes --]

diff --git a/gcc/testsuite/gcc.target/i386/pr98264.c b/gcc/testsuite/gcc.target/i386/pr98264.c
new file mode 100644
index 0000000000000000000000000000000000000000..ea235277911f2a48b4b6f2ccd75a4f9000918599
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr98264.c
@@ -0,0 +1,22 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-O3 -w" } */
+
+a[], g[], h[];
+double b, c;
+double j[];
+i;
+l() {
+  int e = 0;
+  for (; e < 80; e += 4) {
+    a[0] = h[e];
+    a[1] = h[e + 1];
+    j[0] = a[0] - c;
+    j[1] = a[1] + b;
+    __attribute__(()) k = *(double *)a, e, f = e = 0;
+    *g = k;
+    double *d = j;
+    for (; e < 2; e++)
+      if (d[e])
+        i = f;
+  }
+}
diff --git a/gcc/tree-vect-slp-patterns.c b/gcc/tree-vect-slp-patterns.c
index bb2830d1d35d1607d1566868ffbcead97e4790d7..fede88923af8521ee4954c8ae27b0e589f975610 100644
--- a/gcc/tree-vect-slp-patterns.c
+++ b/gcc/tree-vect-slp-patterns.c
@@ -240,7 +240,8 @@ linear_loads_p (slp_tree_to_load_perm_map_t *perm_cache, slp_tree root)
     {
       complex_load_perm_t res = linear_loads_p (perm_cache, child);
       kind = vect_merge_perms (kind, res.first);
-      if (kind == PERM_UNKNOWN)
+      /* Unknown and Top are not valid on blends as they produce no permute.  */
+      if (kind == PERM_UNKNOWN || kind == PERM_TOP)
 	return retval;
       all_loads.safe_push (res.second);
     }