From: Tamar Christina <tamar.christina@arm.com>
To: gcc-patches@gcc.gnu.org
Cc: nd@arm.com, rguenther@suse.de, jlaw@ventanamicro.com
Subject: [PATCH]middle-end: ensure that VEC_PERM operands get lowered to the same SSA_NAME. [PR107717]
Date: Thu, 17 Nov 2022 04:09:49 +0000 [thread overview]
Message-ID: <patch-16601-tamar@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
Hi All,
At the moment when the VEC_PERMs generated by this match.pd rule is generated
it creates two different SSA_NAMEs for the folded operand. Because of this it
the permute switches from a single operand permute to a two operand permute and
the target may no longer support a permute for this.
This fixes it by ensuring we generate the same SSA_NAME for both operands.
Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
Ok for master?
Thanks,
Tamar
gcc/ChangeLog:
PR tree-optimization/107717
* match.pd: Ensure same SSA_NAME.
gcc/testsuite/ChangeLog:
PR tree-optimization/107717
* gcc.target/aarch64/sve2/pr107717.c: New test.
--- inline copy of patch --
diff --git a/gcc/match.pd b/gcc/match.pd
index 82f05bbc912e4f80f3984d930c4a8dcb010136e1..cd510d80d409a7c52ba2a78e2fd7df0fc85cab2b 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -8317,7 +8317,7 @@ and,
(simplify
(op (vec_perm @0 @0 @2) (vec_perm @1 @1 @2))
(if (VECTOR_INTEGER_TYPE_P (type))
- (vec_perm (op @0 @1) (op @0 @1) @2))))
+ (vec_perm (op@3 @0 @1) @3 @2))))
/* Similar for float arithmetic when permutation constant covers
all vector elements. */
@@ -8356,4 +8356,4 @@ and,
}
}
(if (full_perm_p)
- (vec_perm (op @0 @1) (op @0 @1) @2))))))
+ (vec_perm (op@3 @0 @1) @3 @2))))))
--
[-- Attachment #2: rb16601.patch --]
[-- Type: text/plain, Size: 629 bytes --]
diff --git a/gcc/match.pd b/gcc/match.pd
index 82f05bbc912e4f80f3984d930c4a8dcb010136e1..cd510d80d409a7c52ba2a78e2fd7df0fc85cab2b 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -8317,7 +8317,7 @@ and,
(simplify
(op (vec_perm @0 @0 @2) (vec_perm @1 @1 @2))
(if (VECTOR_INTEGER_TYPE_P (type))
- (vec_perm (op @0 @1) (op @0 @1) @2))))
+ (vec_perm (op@3 @0 @1) @3 @2))))
/* Similar for float arithmetic when permutation constant covers
all vector elements. */
@@ -8356,4 +8356,4 @@ and,
}
}
(if (full_perm_p)
- (vec_perm (op @0 @1) (op @0 @1) @2))))))
+ (vec_perm (op@3 @0 @1) @3 @2))))))
next reply other threads:[~2022-11-17 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 4:09 Tamar Christina [this message]
2022-11-17 6:33 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=patch-16601-tamar@arm.com \
--to=tamar.christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=nd@arm.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).