From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] tree-optimization/114921 - _Float16 -> __bf16 isn't noop
Date: Thu, 2 May 2024 14:13:42 +0200 (CEST) [thread overview]
Message-ID: <q5p7s02o-p550-3627-q6no-2n904rr44914@fhfr.qr> (raw)
On Thu, 2 May 2024, Richard Biener wrote:
> The vectorizer handles a _Float16 to __bf16 conversion through
> vectorizable_assignment, thinking it's a noop. The following
> fixes this by making the same-size check stricter, requiring
> the same vector component mode.
>
> Bootstrap & regtest running on x86_64-unknown-linux-gnu. I couldn't
> manage to produce a meaningful (runtime) testcase.
>
> PR tree-optimization/114921
> * tree-vect-stmts.cc (vectorizable_assignment): Require
> same vector component modes for input and output.
> ---
> gcc/tree-vect-stmts.cc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
> index f8d8636b139..5ec053755a2 100644
> --- a/gcc/tree-vect-stmts.cc
> +++ b/gcc/tree-vect-stmts.cc
> @@ -5961,8 +5961,7 @@ vectorizable_assignment (vec_info *vinfo,
> || code == VIEW_CONVERT_EXPR)
> && (!vectype_in
> || maybe_ne (TYPE_VECTOR_SUBPARTS (vectype_in), nunits)
> - || maybe_ne (GET_MODE_SIZE (TYPE_MODE (vectype)),
> - GET_MODE_SIZE (TYPE_MODE (vectype_in)))))
> + || TYPE_MODE (vectype) != TYPE_MODE (vectype_in)))
- || maybe_ne (GET_MODE_SIZE (TYPE_MODE (vectype)),
- GET_MODE_SIZE (TYPE_MODE (vectype_in)))))
+ || (TYPE_MODE (TREE_TYPE (vectype))
+ != TYPE_MODE (TREE_TYPE (vectype_in)))))
actually so it matches the comment in the commit message. ISTR
we have v4si and v2six2 modes on some archs that we possibly want
to inter-operate with through vectorizable_assignment.
Richard.
next reply other threads:[~2024-05-02 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 12:13 Richard Biener [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-02 12:18 Richard Biener
2024-05-02 11:59 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q5p7s02o-p550-3627-q6no-2n904rr44914@fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).