public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* gcc/DATESTAMP wasn't updated since 20240507
@ 2024-05-09 10:04 Rainer Orth
  2024-05-09 10:14 ` Jakub Jelinek
  0 siblings, 1 reply; 5+ messages in thread
From: Rainer Orth @ 2024-05-09 10:04 UTC (permalink / raw)
  To: gcc-patches

I just noticed that gcc/DATESTAMP wasn't updated yesterday and today,
staying at 20240507.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: gcc/DATESTAMP wasn't updated since 20240507
  2024-05-09 10:04 gcc/DATESTAMP wasn't updated since 20240507 Rainer Orth
@ 2024-05-09 10:14 ` Jakub Jelinek
  2024-05-09 11:11   ` Jakub Jelinek
  0 siblings, 1 reply; 5+ messages in thread
From: Jakub Jelinek @ 2024-05-09 10:14 UTC (permalink / raw)
  To: Rainer Orth; +Cc: gcc-patches

On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote:
> I just noticed that gcc/DATESTAMP wasn't updated yesterday and today,
> staying at 20240507.

I think it is because of the r15-268 commit, we do support
This reverts commit ...
when the referenced commit contains a ChangeLog message, but here
it doesn't, as it is a revert commit.

	Jakub


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: gcc/DATESTAMP wasn't updated since 20240507
  2024-05-09 10:14 ` Jakub Jelinek
@ 2024-05-09 11:11   ` Jakub Jelinek
  2024-05-10  6:51     ` Richard Biener
  0 siblings, 1 reply; 5+ messages in thread
From: Jakub Jelinek @ 2024-05-09 11:11 UTC (permalink / raw)
  To: Rainer Orth, Richard Biener, Hans-Peter Nilsson; +Cc: gcc-patches

On Thu, May 09, 2024 at 12:14:43PM +0200, Jakub Jelinek wrote:
> On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote:
> > I just noticed that gcc/DATESTAMP wasn't updated yesterday and today,
> > staying at 20240507.
> 
> I think it is because of the r15-268 commit, we do support
> This reverts commit ...
> when the referenced commit contains a ChangeLog message, but here
> it doesn't, as it is a revert commit.

Indeed and also the r15-311 commit.
Please don't Revert Revert, we don't really support that, had to fix it all
by hand.

	Jakub


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: gcc/DATESTAMP wasn't updated since 20240507
  2024-05-09 11:11   ` Jakub Jelinek
@ 2024-05-10  6:51     ` Richard Biener
  2024-05-13  6:52       ` Rainer Orth
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Biener @ 2024-05-10  6:51 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Rainer Orth, Hans-Peter Nilsson, gcc-patches

On Thu, 9 May 2024, Jakub Jelinek wrote:

> On Thu, May 09, 2024 at 12:14:43PM +0200, Jakub Jelinek wrote:
> > On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote:
> > > I just noticed that gcc/DATESTAMP wasn't updated yesterday and today,
> > > staying at 20240507.
> > 
> > I think it is because of the r15-268 commit, we do support
> > This reverts commit ...
> > when the referenced commit contains a ChangeLog message, but here
> > it doesn't, as it is a revert commit.
> 
> Indeed and also the r15-311 commit.
> Please don't Revert Revert, we don't really support that, had to fix it all
> by hand.

I do wonder if we can run the ChangeLog processing checks as part of
the pre-commit hook and reject such pushes.  It seems we have two
implementations, one in the pre-commit hook and the processing itself
rather than having a single implementation that can run in two modes?

Sorry for the trouble.

Richard.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: gcc/DATESTAMP wasn't updated since 20240507
  2024-05-10  6:51     ` Richard Biener
@ 2024-05-13  6:52       ` Rainer Orth
  0 siblings, 0 replies; 5+ messages in thread
From: Rainer Orth @ 2024-05-13  6:52 UTC (permalink / raw)
  To: Richard Biener; +Cc: Jakub Jelinek, Hans-Peter Nilsson, gcc-patches

Richard Biener <rguenther@suse.de> writes:

> On Thu, 9 May 2024, Jakub Jelinek wrote:
>
>> On Thu, May 09, 2024 at 12:14:43PM +0200, Jakub Jelinek wrote:
>> > On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote:
>> > > I just noticed that gcc/DATESTAMP wasn't updated yesterday and today,
>> > > staying at 20240507.
>> > 
>> > I think it is because of the r15-268 commit, we do support
>> > This reverts commit ...
>> > when the referenced commit contains a ChangeLog message, but here
>> > it doesn't, as it is a revert commit.
>> 
>> Indeed and also the r15-311 commit.
>> Please don't Revert Revert, we don't really support that, had to fix it all
>> by hand.
>
> I do wonder if we can run the ChangeLog processing checks as part of
> the pre-commit hook and reject such pushes.  It seems we have two
> implementations, one in the pre-commit hook and the processing itself
> rather than having a single implementation that can run in two modes?

Unfortunately, the datestamp is again stuck at 20240509.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-05-13  6:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 10:04 gcc/DATESTAMP wasn't updated since 20240507 Rainer Orth
2024-05-09 10:14 ` Jakub Jelinek
2024-05-09 11:11   ` Jakub Jelinek
2024-05-10  6:51     ` Richard Biener
2024-05-13  6:52       ` Rainer Orth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).