From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 6AE603858C2C; Tue, 28 Sep 2021 11:28:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6AE603858C2C Received: from relay1.suse.de (relay1.suse.de [149.44.160.133]) by smtp-out2.suse.de (Postfix) with ESMTP id 5D1FF1FFA4; Tue, 28 Sep 2021 11:28:04 +0000 (UTC) Received: from murzim.suse.de (murzim.suse.de [10.160.4.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay1.suse.de (Postfix) with ESMTPS id 56A0B25D94; Tue, 28 Sep 2021 11:28:04 +0000 (UTC) Date: Tue, 28 Sep 2021 13:28:04 +0200 (CEST) From: Richard Biener To: Ilya Leoshkevich cc: gcc-patches@gcc.gnu.org, Andreas Krebbel Subject: Re: [PATCH v3 3/3] reassoc: Test rank biasing In-Reply-To: <20210926110936.344019-4-iii@linux.ibm.com> Message-ID: References: <20210926110936.344019-1-iii@linux.ibm.com> <20210926110936.344019-4-iii@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 11:28:07 -0000 On Sun, 26 Sep 2021, Ilya Leoshkevich wrote: > Add both positive and negative tests. The tests will likely be quite fragile with respect to what is actually vectorized on which target. If you move the tests to gcc.dg/vect/ you could at least do /* { dg-require-effective-target vect_int } */ do you need to look for the exact GIMPLE IL or is it enough to verify we are vectorizing the reduction? Thanks, Richard. > gcc/testsuite/ChangeLog: > > * gcc.dg/tree-ssa/reassoc-46.c: New test. > * gcc.dg/tree-ssa/reassoc-46.h: Common code for new tests. > * gcc.dg/tree-ssa/reassoc-47.c: New test. > * gcc.dg/tree-ssa/reassoc-48.c: New test. > * gcc.dg/tree-ssa/reassoc-49.c: New test. > * gcc.dg/tree-ssa/reassoc-50.c: New test. > * gcc.dg/tree-ssa/reassoc-51.c: New test. > --- > gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.c | 7 +++++ > gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.h | 33 ++++++++++++++++++++++ > gcc/testsuite/gcc.dg/tree-ssa/reassoc-47.c | 9 ++++++ > gcc/testsuite/gcc.dg/tree-ssa/reassoc-48.c | 9 ++++++ > gcc/testsuite/gcc.dg/tree-ssa/reassoc-49.c | 11 ++++++++ > gcc/testsuite/gcc.dg/tree-ssa/reassoc-50.c | 10 +++++++ > gcc/testsuite/gcc.dg/tree-ssa/reassoc-51.c | 11 ++++++++ > 7 files changed, 90 insertions(+) > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.c > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.h > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/reassoc-47.c > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/reassoc-48.c > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/reassoc-49.c > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/reassoc-50.c > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/reassoc-51.c > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.c b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.c > new file mode 100644 > index 00000000000..97563dd929f > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.c > @@ -0,0 +1,7 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-optimized -ftree-vectorize" } */ > + > +#include "reassoc-46.h" > + > +/* Check that the loop accumulator is added last. */ > +/* { dg-final { scan-tree-dump-times {(?:vect_)?sum_[\d._]+ = (?:(?:vect_)?_[\d._]+ \+ (?:vect_)?sum_[\d._]+|(?:vect_)?sum_[\d._]+ \+ (?:vect_)?_[\d._]+)} 1 "optimized" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.h b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.h > new file mode 100644 > index 00000000000..e60b490ea0d > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-46.h > @@ -0,0 +1,33 @@ > +#define M 1024 > +unsigned int arr1[M]; > +unsigned int arr2[M]; > +volatile unsigned int sink; > + > +unsigned int > +test (void) > +{ > + unsigned int sum = 0; > + for (int i = 0; i < M; i++) > + { > +#ifdef MODIFY > + /* Modify the loop accumulator using a chain of operations - this should > + not affect its rank biasing. */ > + sum |= 1; > + sum ^= 2; > +#endif > +#ifdef STORE > + /* Save the loop accumulator into a global variable - this should not > + affect its rank biasing. */ > + sink = sum; > +#endif > +#ifdef USE > + /* Add a tricky use of the loop accumulator - this should prevent its > + rank biasing. */ > + i = (i + sum) % M; > +#endif > + /* Use addends with different ranks. */ > + sum += arr1[i]; > + sum += arr2[((i ^ 1) + 1) % M]; > + } > + return sum; > +} > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/reassoc-47.c b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-47.c > new file mode 100644 > index 00000000000..1b0f0fdabe1 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-47.c > @@ -0,0 +1,9 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-optimized -ftree-vectorize" } */ > + > +#define MODIFY > +#include "reassoc-46.h" > + > +/* Check that if the loop accumulator is saved into a global variable, it's > + still added last. */ > +/* { dg-final { scan-tree-dump-times {(?:vect_)?sum_[\d._]+ = (?:(?:vect_)?_[\d._]+ \+ (?:vect_)?sum_[\d._]+|(?:vect_)?sum_[\d._]+ \+ (?:vect_)?_[\d._]+)} 1 "optimized" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/reassoc-48.c b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-48.c > new file mode 100644 > index 00000000000..13836ebe8e6 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-48.c > @@ -0,0 +1,9 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-optimized -ftree-vectorize" } */ > + > +#define STORE > +#include "reassoc-46.h" > + > +/* Check that if the loop accumulator is modified using a chain of operations > + other than addition, its new value is still added last. */ > +/* { dg-final { scan-tree-dump-times {(?:vect_)?sum_[\d._]+ = (?:(?:vect_)?_[\d._]+ \+ (?:vect_)?sum_[\d._]+|(?:vect_)?sum_[\d._]+ \+ (?:vect_)?_[\d._]+)} 1 "optimized" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/reassoc-49.c b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-49.c > new file mode 100644 > index 00000000000..c1136a447a2 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-49.c > @@ -0,0 +1,11 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-optimized -ftree-vectorize" } */ > + > +#define MODIFY > +#define STORE > +#include "reassoc-46.h" > + > +/* Check that if the loop accumulator is both modified using a chain of > + operations other than addition and stored into a global variable, its new > + value is still added last. */ > +/* { dg-final { scan-tree-dump-times {(?:vect_)?sum_[\d._]+ = (?:(?:vect_)?_[\d._]+ \+ (?:vect_)?sum_[\d._]+|(?:vect_)?sum_[\d._]+ \+ (?:vect_)?_[\d._]+)} 1 "optimized" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/reassoc-50.c b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-50.c > new file mode 100644 > index 00000000000..e35a4ff1278 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-50.c > @@ -0,0 +1,10 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-optimized -ftree-vectorize" } */ > + > +#define MODIFY > +#define USE > +#include "reassoc-46.h" > + > +/* Check that if the loop accumulator has multiple uses inside the loop, it's > + not forced to the end of the reassociation chain. */ > +/* { dg-final { scan-tree-dump-times {(?:vect_)?sum_[\d._]+ = (?:(?:vect_)?_[\d._]+ \+ (?:vect_)?sum_[\d._]+|(?:vect_)?sum_[\d._]+ \+ (?:vect_)?_[\d._]+)} 2 "optimized" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/reassoc-51.c b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-51.c > new file mode 100644 > index 00000000000..07175675e24 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/reassoc-51.c > @@ -0,0 +1,11 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-optimized -ftree-vectorize" } */ > + > +#define MODIFY > +#define STORE > +#define USE > +#include "reassoc-46.h" > + > +/* Check that if the loop accumulator has multiple uses inside the loop, it's > + not forced to the end of the reassociation chain. */ > +/* { dg-final { scan-tree-dump-times {(?:vect_)?sum_[\d._]+ = (?:(?:vect_)?_[\d._]+ \+ (?:vect_)?sum_[\d._]+|(?:vect_)?sum_[\d._]+ \+ (?:vect_)?_[\d._]+)} 2 "optimized" } } */