From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rguenther@suse.de>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by sourceware.org (Postfix) with ESMTPS id 7A542387743E
 for <gcc-patches@gcc.gnu.org>; Mon, 29 Nov 2021 10:19:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A542387743E
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id 4F9891FCA1;
 Mon, 29 Nov 2021 10:19:36 +0000 (UTC)
Received: from murzim.suse.de (murzim.suse.de [10.160.4.192])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 47E64A3B8B;
 Mon, 29 Nov 2021 10:19:36 +0000 (UTC)
Date: Mon, 29 Nov 2021 11:19:36 +0100 (CET)
From: Richard Biener <rguenther@suse.de>
To: Jeff Law <jeffreyalaw@gmail.com>
cc: gcc-patches@gcc.gnu.org, polacek@redhat.com
Subject: Re: [PATCH] Remove unreachable returns
In-Reply-To: <08176a9d-ac1a-123d-9466-9c2040a5f2ef@gmail.com>
Message-ID: <qqo71q36-2020-rno2-46s0-n47n31566o9o@fhfr.qr>
References: <80qqs862-prn1-369p-94n4-qq8qoq34os1@fhfr.qr>
 <08176a9d-ac1a-123d-9466-9c2040a5f2ef@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Nov 2021 10:19:42 -0000

On Sun, 28 Nov 2021, Jeff Law wrote:

> 
> 
> On 11/25/2021 7:16 AM, Richard Biener via Gcc-patches wrote:
> > This removes unreachable return statements as diagnosed by
> > the -Wunreachable-code patch.  Some cases are more obviously
> > an improvement than others - in fact some may get you the idea
> > to replace them with gcc_unreachable () instead, leading to
> > cases of the 'Remove unreachable gcc_unreachable () at the end
> > of functions' patch.
> >
> > Bootstrapped and tested on x86_64-unknown-linux-gnu.
> >
> > OK?  Comments?  Feel free to approve select cases only.
> >
> > Thanks,
> > Richard.
> >
> > 2021-11-25  Richard Biener  <rguenther@suse.de>
> >
> >  * vec.c (qsort_chk): Do not return the void return value
> >  from the noreturn qsort_chk_error.
> >  * ccmp.c (expand_ccmp_expr_1): Remove unreachable return.
> >  * df-scan.c (df_ref_equal_p): Likewise.
> >  * dwarf2out.c (is_base_type): Likewise.
> >  (add_const_value_attribute): Likewise.
> >  * fixed-value.c (fixed_arithmetic): Likewise.
> >  * gimple-fold.c (gimple_fold_builtin_fputs): Likewise.
> >  * gimple-ssa-strength-reduction.c (stmt_cost): Likewise.
> >  * graphite-isl-ast-to-gimple.c
> >  (gcc_expression_from_isl_expr_op): Likewise.
> >  (gcc_expression_from_isl_expression): Likewise.
> >  * ipa-fnsummary.c (will_be_nonconstant_expr_predicate):
> >  Likewise.
> >  * lto-streamer-in.c (lto_input_mode_table): Likewise.
> >
> > gcc/c-family/
> >  * c-opts.c (c_common_post_options): Remove unreachable return.
> >  * c-pragma.c (handle_pragma_target): Likewise.
> >  (handle_pragma_optimize): Likewise.
> >
> > gcc/c/
> >  * c-typeck.c (c_tree_equal): Remove unreachable return.
> >  * c-parser.c (get_matching_symbol): Likewise.
> >
> > libgomp/
> >  * oacc-plugin.c (GOMP_PLUGIN_acc_default_dim): Remove unreachable
> >  return.
> I'd commit the whole set.

I have pushed it.

Richard.