From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 4ABE8382FADF for ; Fri, 28 Jun 2024 06:17:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4ABE8382FADF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4ABE8382FADF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719555457; cv=none; b=C+5aDyVK7S+ZRL4BrfQa3kvFe53FwL6PaQqD6JPjszaHbZVHhmQarD12rfiizDwBljKKpIxffc/OqfNol7ph7MGMZi4+Y0rTlgf+/B1URWOwgOlHLslMqWvLkjOYckxXzYJA5JgBysU0dOM4WCYT0COWeT00Efc9v9v3vWNP9wo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719555457; c=relaxed/simple; bh=D3jJgNSeZy1aRP0Hye7XHl/zXUConSzax88zYiBTHq4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=o6KisofjoTrfCMjenlj9B3jNmfZ5TkGCM8xqsT4+n6V3jbAgLVtGrP6kLS1DmybHmx16bL01YVe79RGf4OB5TahbIM2WU1lIT5HKWX+9b8Hi8TA9lT/YFVUXe1D/c57LtawBtGoyruD1JoEI95Dlq53PSuwpnZKF0dmcyCihWh0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1D49921B54; Fri, 28 Jun 2024 06:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1719555455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gS3CVRMfYV6rXhxoZjec2BGlK7ZbERSTjog3RAz7l4=; b=lMt0Pms89RKr3iGThT0DkLa+P51jiXRgaFms+5YjqHxmmLgbIXISTWFkd3hiOMcGQxizEC A89w/tDC2Hxb+FQEjzbQYl+9YRaZWo6ywDQqCj0jDDmq70r+rkZprqz/NdmnSbENLqxEvY LqS0XxC65Ayu18ezMIU5od5p6x/cv/0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1719555455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gS3CVRMfYV6rXhxoZjec2BGlK7ZbERSTjog3RAz7l4=; b=JvVkXW8V+C/9fpND0jXkDgfZl/eBjrkpWVm2iZ+sORMf9NUvxcE4/fULrXkkfCHoiZx1DV M4B2woxhHXPs05Bw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1719555455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gS3CVRMfYV6rXhxoZjec2BGlK7ZbERSTjog3RAz7l4=; b=lMt0Pms89RKr3iGThT0DkLa+P51jiXRgaFms+5YjqHxmmLgbIXISTWFkd3hiOMcGQxizEC A89w/tDC2Hxb+FQEjzbQYl+9YRaZWo6ywDQqCj0jDDmq70r+rkZprqz/NdmnSbENLqxEvY LqS0XxC65Ayu18ezMIU5od5p6x/cv/0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1719555455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gS3CVRMfYV6rXhxoZjec2BGlK7ZbERSTjog3RAz7l4=; b=JvVkXW8V+C/9fpND0jXkDgfZl/eBjrkpWVm2iZ+sORMf9NUvxcE4/fULrXkkfCHoiZx1DV M4B2woxhHXPs05Bw== Date: Fri, 28 Jun 2024 08:17:35 +0200 (CEST) From: Richard Biener To: FX Coudert cc: Jakub Jelinek , GCC Patches , dmalcolm@redhat.com, Iain Sandoe , Eric Gallager , josmyers@redhat.com Subject: Re: [PATCH] jit: Ensure ssize_t is defined. In-Reply-To: <0FAD60A0-E61E-463A-AC39-12CDED6CACD3@gmail.com> Message-ID: References: <2E73A53A-AF7C-4696-BD97-C7DA47F6DF94@gmail.com> <719A0D36-BE49-45AE-A1DB-3A3B445FFDFA@gmail.com> <7nnp73r2-7qsq-0o84-720p-888o13743511@fhfr.qr> <0FAD60A0-E61E-463A-AC39-12CDED6CACD3@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1475677436-1120086104-1719555455=:4147" X-Spamd-Result: default: False [-3.25 / 50.00]; BAYES_HAM(-3.00)[99.99%]; CTYPE_MIXED_BOGUS(1.00)[]; NEURAL_HAM_LONG(-0.95)[-0.946]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; RCPT_COUNT_SEVEN(0.00)[7]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Spam-Score: -3.25 X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1475677436-1120086104-1719555455=:4147 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 27 Jun 2024, FX Coudert wrote: > Among the review comments from the last round, Jakub suggested: > > > Perhaps libgccjit.h could use > > #ifdef __has_include > > #if __has_include () > > #include > > #endif > > #endif > > instead of just #include . > > I’m not sure it’s necessary since other headers treat as always available, but I suppose it can’t hurt. So here is a revised patch as suggested. But isn't the bigger issue that sys/types.h isn't guaranteed to contain a declaration of ssize_t? And that when sys/types.h isn't available we don't get ssize_t from it either? That said, maybe we're fine with this but then I walk back and say just unconditionally include sys/types.h ... > Bootstrapped on x86_64-apple-darwin23. OK to push? Should be Davids say as he added this API. Richard. ---1475677436-1120086104-1719555455=:4147--