From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 2CCE43858281 for ; Fri, 30 Jun 2023 14:40:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CCE43858281 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 513961F74A; Fri, 30 Jun 2023 14:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688136030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rnL2FJPglEBpe/N4Gx/93rdeLqBytJ2sIVh6PO2TGIE=; b=OQxNaSk2eaP2VGIJ/wq4kkFLL1cIsaNPkmFcPB1hyNU3PdGXNZ1nxV3TeOcFkB2kHfxA50 +63Mlh2tHSnq/2SQygfophnCEzcKb3P5q95k90PvR6+Kzy4bDbA400pouHcXSl9D2lvmdA Gv/cdnprgMClcP/aezeQKcxLNyF9cpo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688136030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rnL2FJPglEBpe/N4Gx/93rdeLqBytJ2sIVh6PO2TGIE=; b=2YNxL11viPvajfD8T/rMgFip1+erRO/ylM3nKK9flChzEpt23KhkdnA3MSZaJvcRRj+fpc +ITZAh2Hw+Me5JAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 435AC13915; Fri, 30 Jun 2023 14:40:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D9vcD17pnmSvBwAAMHmgww (envelope-from ); Fri, 30 Jun 2023 14:40:30 +0000 From: Martin Jambor To: David Malcolm Cc: GCC Patches Subject: Re: [PATCH 3/3] analyzer: add text-art visualizations of out-of-bounds accesses [PR106626] In-Reply-To: <20230531180630.3127108-4-dmalcolm@redhat.com> References: <20230531180630.3127108-1-dmalcolm@redhat.com> <20230531180630.3127108-4-dmalcolm@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.2 (x86_64-suse-linux-gnu) Date: Fri, 30 Jun 2023 16:40:29 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi David, On Wed, May 31 2023, David Malcolm via Gcc-patches wrote: > This patch extends -Wanalyzer-out-of-bounds so that, where possible, it > will emit a text art diagram visualizing the spatial relationship between [...] > > gcc/ChangeLog: > PR analyzer/106626 > * Makefile.in (ANALYZER_OBJS): Add analyzer/access-diagram.o. > * doc/invoke.texi (Wanalyzer-out-of-bounds): Add description of > text art. > (fanalyzer-debug-text-art): New. > > gcc/analyzer/ChangeLog: > PR analyzer/106626 > * access-diagram.cc: New file. > * access-diagram.h: New file. > * analyzer.h (class region_offset): Add default ctor. > (region_offset::make_byte_offset): New decl. > (region_offset::concrete_p): New. > (region_offset::get_concrete_byte_offset): New. > (region_offset::calc_symbolic_bit_offset): New decl. > (region_offset::calc_symbolic_byte_offset): New decl. > (region_offset::dump_to_pp): New decl. > (region_offset::dump): New decl. > (operator<, operator<=, operator>, operator>=): New decls for > region_offset. > * analyzer.opt > (-param=analyzer-text-art-string-ellipsis-threshold=): New. > (-param=analyzer-text-art-string-ellipsis-head-len=): New. > (-param=analyzer-text-art-string-ellipsis-tail-len=): New. > (-param=analyzer-text-art-ideal-canvas-width=): New. contrib/check-params-in-docs.py now complains that: $ ./gcc/xgcc -Bgcc --help=param &>/tmp/params.txt $ ../src/contrib/check-params-in-docs.py ../src/gcc/doc/invoke.texi /tmp/params.txt Missing: @item analyzer-text-art-string-ellipsis-threshold The number of bytes at which to ellipsize string literals in @item analyzer-text-art-string-ellipsis-head-len The number of literal bytes to show at the head of a string @item analyzer-text-art-string-ellipsis-tail-len The number of literal bytes to show at the tail of a string @item analyzer-text-art-ideal-canvas-width The ideal width in characters of text art diagrams generated by the Can you please add the respective documentation entries? Thanks! Martin