From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=wo5W=55=suse.cz=mjambor@sourceware.org>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d])
	by sourceware.org (Postfix) with ESMTPS id 4BE1D3858D33
	for <gcc-patches@gcc.gnu.org>; Wed,  1 Feb 2023 14:26:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BE1D3858D33
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out2.suse.de (Postfix) with ESMTPS id 2707F1FE10;
	Wed,  1 Feb 2023 14:26:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1675261612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RZ5wJCSMuc58SmeKIujqSQCvIwjjWhPaDm+enmFBmw0=;
	b=apie65yc9XJ58tWzuufQQhFUKelJJFr5rUDHc1v6RiVI8W2BQG1P2MVVY8NWyws2AMNeov
	ORAQVLsYm/P4LbLxwLQMI54S9u8GiC4t4IZY7e5DFphN18l6ylz3Lqk9cuUi5/XfxLIodu
	E1GvX71nDZ4nV0jF7DQO6+KuxO4rsTc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1675261612;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RZ5wJCSMuc58SmeKIujqSQCvIwjjWhPaDm+enmFBmw0=;
	b=BLXMeTgx+0M+ZpZkWCouS4rfXblIGY5YGvolXobZfAU0t/npQdVY5VLkJhC3npRvMGpMmb
	ZlWjbcTvVsStGDDg==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 196831348C;
	Wed,  1 Feb 2023 14:26:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id YVsnBqx22mOYdAAAMHmgww
	(envelope-from <mjambor@suse.cz>); Wed, 01 Feb 2023 14:26:52 +0000
From: Martin Jambor <mjambor@suse.cz>
To: Martin =?utf-8?Q?Li=C5=A1ka?= <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Cc: Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] ipa: silent -Wodr notes with -w
In-Reply-To: <c210778d-e7d8-5d00-7255-329f7dfec052@suse.cz>
References: <c210778d-e7d8-5d00-7255-329f7dfec052@suse.cz>
User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.2
 (x86_64-suse-linux-gnu)
Date: Wed, 01 Feb 2023 15:26:45 +0100
Message-ID: <ri6cz6tbgwq.fsf@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Hi,

On Fri, Dec 02 2022, Martin Li=C5=A1ka wrote:
> If -w is used, warn_odr properly sets *warned =3D false and
> so it should be preserved when calling warn_types_mismatch.
>
> Noticed that during a LTO reduction where I used -w.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 	* ipa-devirt.cc (odr_types_equivalent_p): Respect *warned
> 	value if set.

Sorry for skipping this for so long, usually ODR stuff is... interesting
to the point I gladly leave it to Honza.

Please go ahead and commit the patch.  The way I read the code, your
version must have been the intended behavior and the dereference is
missing.

Thanks,

Martin