From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 410A73858D1E for ; Mon, 6 Feb 2023 14:16:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 410A73858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 553AB60591; Mon, 6 Feb 2023 14:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675692970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QCg06n83ubCMybo0ls71KsijXmnGQsK4phsvjk2OQGc=; b=L/F4h7wNJtQ2vUFLKwMw8WuO/l3/bzXyXfW7vD2MocK7iNszfpf4HbjWF2s+tpJ9ULLwK6 K0POmXitEGXR9AmvFSVx1aUZx55UR7ByPCzSixi974Rws89WW56HIqKvuuovANngvUHMRN l9yZt6m48FRs/vlN27xKC6nPyXE+fbE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675692970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QCg06n83ubCMybo0ls71KsijXmnGQsK4phsvjk2OQGc=; b=wRL2OnnP9eYiK+zafd3wRGufGr3kBpjw/7a331TgB533cELjsa+02n1CDq1n+Fvz4frgDG ua//IFzdhJF3UfCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A157138E7; Mon, 6 Feb 2023 14:16:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ra0FEqoL4WPEQwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:16:10 +0000 From: Martin Jambor To: Bernhard Reutner-Fischer Cc: GCC Patches Subject: Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384) In-Reply-To: <07DD5AA3-1575-4DD6-8EA8-9B733AAE4D2C@gmail.com> References: <07DD5AA3-1575-4DD6-8EA8-9B733AAE4D2C@gmail.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.2 (x86_64-suse-linux-gnu) Date: Mon, 06 Feb 2023 15:16:09 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Fri, Feb 03 2023, Bernhard Reutner-Fischer wrote: > On 3 February 2023 12:35:32 CET, Richard Biener via Gcc-patches >> >>I think it's OK as-is given this explanation. >> > > s/derefernce/dereference/ > Thanks for noticing. I am about to commit the following as an obvious fix. Martin A fix to a typo spotted by Bernhard Reutner-Fischer. Tested by building the compiler with the fix. gcc/ChangeLog: 2023-02-06 Martin Jambor * ipa-sra.cc (adjust_parameter_descriptions): Fix a typo in a dump. --- gcc/ipa-sra.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc index 7a2b4dc8608..0495f446bf4 100644 --- a/gcc/ipa-sra.cc +++ b/gcc/ipa-sra.cc @@ -4249,8 +4249,8 @@ adjust_parameter_descriptions (cgraph_node *node, isra_func_summary *ifs) dump_list_of_param_indices (node, "are dead on arrival or have a type " "mismatch with IPA-CP", dump_dead_indices); - dump_list_of_param_indices (node, "are not safe to derefernce in all callers", - dump_bad_cond_indices); + dump_list_of_param_indices (node, "are not safe to dereference in all " + "callers", dump_bad_cond_indices); return ret; } -- 2.39.0