From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 6F6583858C66 for ; Mon, 6 Nov 2023 17:03:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F6583858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F6583858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699290189; cv=none; b=LXmxOEBSy3LNc3TPdjM+pmgeLdK1zfE5XNQLnY68I1cKQNfIpek9fEtyI4U/3XauJq9WD7SuiV73bJua3yjAqPHIbb2HjCIDyzcycvbFQVXftuc0/dYwGOgpKEIEmFklYWe9eQW38odMCc+LExwS70x4HYTPqawPehoVPSLP2BM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699290189; c=relaxed/simple; bh=rSveP4e9/bDW8QEGGOIUzBX3LCIjpbkpDPCwTDvUOGs=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=QdCZ+E/lXRvJ7yjiu39gwNd7oLmevvg8lqoICeWNG67DVcIwBxAIGa+biD3aFo4CAWkz1tYpxRqt4+PCdU1/k7An+BfzXK8ugcpsj+SBpM1tPXxp6lHNZ2Oix3EISoLkTg2018pysVeEvHeFaGYZCfO7XaKNMnNa7JqYwD/JMOU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90994200DC; Mon, 6 Nov 2023 17:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1699290186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6LktqMbEWsdjvcLe0pUYr6IIZhT/2XcNxIRgJrgmRj4=; b=H0d3/OAmRx1t+up8p+DorLBtXK83Tsx/Lt3QHWnMZKZFNQmse8yruCWxX5jP7Ipe7h8EtG 54ZsjxTFlrsT0n5yt5fBPH3BdV/h/9AjygpbHf7LXQ6SJES/lrOxLIfx17Gx04zdqWdKgx 3l4/E0y94RVB2MtmbgzHxERj7f2BNpA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1699290186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6LktqMbEWsdjvcLe0pUYr6IIZhT/2XcNxIRgJrgmRj4=; b=Gxb0Tei5xDpQwVH5FKELWSEuvwjbvGql86bydR8lbpFfNowWz4HYNwoKg9v1AHCbV20h9C zMIh5nWERagWqxAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E565138F3; Mon, 6 Nov 2023 17:03:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2byyHkocSWUrWAAAMHmgww (envelope-from ); Mon, 06 Nov 2023 17:03:06 +0000 From: Martin Jambor To: Robin Dapp , gcc-patches Cc: jeffreyalaw Subject: [PATCH] Fix configure script comments(!?!) (Was: Re: [PATCH] genemit: Split insn-emit.cc into ten files) In-Reply-To: References: User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.1 (x86_64-suse-linux-gnu) Date: Mon, 06 Nov 2023 18:03:05 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,INVALID_MSGID,KAM_ASCII_DIVIDERS,PLING_QUERY,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Thu, Oct 12 2023, Robin Dapp wrote: > [...] > gcc/ChangeLog: > > PR bootstrap/84402 > PR target/111600 > > * Makefile.in: Handle split insn-emit.cc. > * configure: Regenerate. > * configure.ac: Add --with-insnemit-partitions. > * genemit.cc (output_peephole2_scratches): Print to file instead > of stdout. > (print_code): Ditto. > (gen_rtx_scratch): Ditto. > (gen_exp): Ditto. > (gen_emit_seq): Ditto. > (emit_c_code): Ditto. > (gen_insn): Ditto. > (gen_expand): Ditto. > (gen_split): Ditto. > (output_add_clobbers): Ditto. > (output_added_clobbers_hard_reg_p): Ditto. > (print_overload_arguments): Ditto. > (print_overload_test): Ditto. > (handle_overloaded_code_for): Ditto. > (handle_overloaded_gen): Ditto. > (print_header): New function. > (handle_arg): New function. > (main): Split output into 10 files. > * gensupport.cc (count_patterns): New function. > * gensupport.h (count_patterns): Define. > * read-md.cc (md_reader::print_md_ptr_loc): Add file argument. > * read-md.h (class md_reader): Change definition. Following this commit, our buildbot script which checks that configure scripts where re-generated correctly is unhappy because it insists comments are wrong, it wants to them to be like this: ------------------------------------------------------------ diff --git a/gcc/configure b/gcc/configure index 4d0357cbc28..0d818ae6850 100755 --- a/gcc/configure +++ b/gcc/configure @@ -20000,7 +20000,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 19995 "configure" +#line 20003 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -20106,7 +20106,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 20101 "configure" +#line 20109 "configure" #include "confdefs.h" #if HAVE_DLFCN_H ------------------------------------------------------------ I'm not sure what that means, whether a wrong version of autoconf/automake was used (though when I accidentally tried that, it has always complained loudly) or if some environment difference can cause this. Perhaps I should change the script not to care about commits though that won't happen soon (or perhaps I should drop the checks completely) but would people be OK with me checking in the patch above (with appropriate ChangeLog) to silence buildbot for a while again? Thanks, Martin