From: Martin Jambor <mjambor@suse.cz>
To: Andrea Corallo <Andrea.Corallo@arm.com>,
"gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"jit\@gcc.gnu.org" <jit@gcc.gnu.org>
Cc: nd <nd@arm.com>, Jan Hubicka <hubicka@ucw.cz>, Jan Hubicka <jh@suse.cz>
Subject: Re: [PATCH] IPA-CP release transformation summary (PR jit/91928)
Date: Mon, 30 Sep 2019 09:19:00 -0000 [thread overview]
Message-ID: <ri6k19q2lbd.fsf@suse.cz> (raw)
In-Reply-To: <gkrlfu6uphd.fsf@arm.com>
Hi,
On Mon, Sep 30 2019, Andrea Corallo wrote:
> Hi all,
> I'd like to submit this patch.
> It release the ipa cp transformation summary after functions being expanded.
> This is to fix the compiler when used with libgccjit on subsequent
> compilations (every new compilation should have a clean transformation
> summary).
if this is a general problem then I think we should instead add another
hook to class ipa_opt_pass_d to free transformation summary, call it for
all IPA passes at the appropriate time and implement it for IPA-CP. That
way it will work for all IPA passes which might have a transformation
summary.
Martin
>
> Bootstrap on arm64 and X86-64.
>
> Bests
> Andrea
>
> gcc/ChangeLog
> 2019-??-?? Andrea Corallo <andrea.corallo@arm.com>
>
> * cgraphunit.c (expand_all_functions): Release ipcp_transformation_sum
> when finished.
> * ipa-prop.c (ipcp_free_transformation_sum): New function.
> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration.
next prev parent reply other threads:[~2019-09-30 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 9:07 Andrea Corallo
2019-09-30 9:19 ` Martin Jambor [this message]
2019-10-01 10:11 ` Andrea Corallo
2019-10-01 20:35 ` Jeff Law
2019-10-03 12:47 ` Andrea Corallo
2019-10-04 1:27 ` Jeff Law
2019-10-05 9:07 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ri6k19q2lbd.fsf@suse.cz \
--to=mjambor@suse.cz \
--cc=Andrea.Corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jh@suse.cz \
--cc=jit@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).