From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id A09FC3858419 for ; Wed, 27 Oct 2021 13:22:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A09FC3858419 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D8AE8212B7 for ; Wed, 27 Oct 2021 13:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635340938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nw92otCc+8RG9HqWo+ljnD3xZQAOvxjtfoabwqnfUYI=; b=ljERCl06H6FCR128FdmST8ta8Evdupn/vx4q6wo+Jlf/K4oW/biHgDPISdomVQdwDSj5JW bHuZ7SPfLKGMSCJnwhP82+F3Q5f7gV0otHoLKhGA+cfZOds5EvU/KSD4uphimy/sFhOtPY IsY3509TyhAnLB2ln/7w5b8usEzeNsk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635340938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nw92otCc+8RG9HqWo+ljnD3xZQAOvxjtfoabwqnfUYI=; b=uGbMrc8SItY0KJxnth/zox0cExC+xCQsrMhL0sQWCAaW1Yt+2r8iu6MGaED7CTAGKTPOUj P+vl/cBCxE3BX3BQ== Received: from suse.cz (virgil.suse.cz [10.100.13.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C311EA3B84 for ; Wed, 27 Oct 2021 13:22:18 +0000 (UTC) From: Martin Jambor To: GCC Patches Subject: Re: [PATCH 4/4] ipa-cp: Select saner profile count to base heuristics on In-Reply-To: References: <96160a5131c9e5eb302fb9f4db43c5d8b4cfe042.1629805719.git.mjambor@suse.cz> <20211006153340.GA64649@kam.mff.cuni.cz> User-Agent: Notmuch/0.33.2 (https://notmuchmail.org) Emacs/27.2 (x86_64-suse-linux-gnu) Date: Wed, 27 Oct 2021 15:22:18 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 13:22:20 -0000 Hi, On Mon, Oct 18 2021, Martin Jambor wrote: > [...] > > > This is a follow-up small patch to address Honza's review of my > previous patch to select saner profile count to base heuristics on. > Currently the IPA-CP heuristics switch to PGO-mode only if there are > PGO counters available for any part of the call graph. This change > makes it to switch to the PGO mode only if any of the incoming edges > bringing in the constant in question had any ipa-quality counts on > them. Consequently, if a part of the program is built with > -fprofile-use and another part without, IPA-CP will use > estimated-frequency-based heuristics for the latter. > > I still wonder whether this should only happen with > flag_profile_partial_training on. It seems like we're behaving as if > it was always on. > Honza approved this patch in a private conversation and so I have pushed it to master as commit ab810952eb7c061e37054ddd1dfe0aa033365131. Thanks, Martin