public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Jambor <mjambor@suse.cz>
To: Xionghu Luo <luoxhu@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Run pass_sink_code once more before store_mergin
Date: Thu, 02 Sep 2021 17:45:34 +0200	[thread overview]
Message-ID: <ri6tuj37zhd.fsf@suse.cz> (raw)
In-Reply-To: <763796a2-fe9a-a3bf-c48c-a6ae39e9fa74@linux.ibm.com>

Hi,

On Tue, May 18 2021, Xionghu Luo via Gcc-patches wrote:
>

[...]

> From 7fcc6ca9ef3b6acbfbcbd3da4be1d1c0eef4be80 Mon Sep 17 00:00:00 2001
> From: Xiong Hu Luo <luoxhu@linux.ibm.com>
> Date: Mon, 17 May 2021 20:46:15 -0500
> Subject: [PATCH] Run pass_sink_code once more before store_merging
>
> Gimple sink code pass runs quite early, there may be some new
> oppertunities exposed by later gimple optmization passes, this patch
> runs the sink code pass once more before store_merging.  For detailed
> discussion, please refer to:
> https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562352.html
>
> Tested the SPEC2017 performance on P8LE, 544.nab_r is improved
> by 2.43%, but no big changes to other cases, GEOMEAN is improved quite
> small with 0.25%.
>
> gcc/ChangeLog:
>
> 	* passes.def: Add sink_code before store_merging.
> 	* tree-ssa-sink.c (pass_sink_code:clone): New.


Unfortunately, this seems to have caused PR 102178
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102178)

Sorry about the bad news,

Martin


  parent reply	other threads:[~2021-09-02 15:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21  9:03 [RFC] Run pass_sink_code once more after ivopts/fre Xiong Hu Luo
2020-12-22 16:53 ` Richard Biener
2021-03-23  3:07   ` Xionghu Luo
2021-03-23  8:50     ` Richard Biener
2021-03-26  7:35       ` Xionghu Luo
2021-04-14  1:51         ` Xionghu Luo
2021-04-14  6:41           ` Richard Biener
2021-04-15  6:20             ` Xionghu Luo
2021-04-15 11:34               ` Richard Biener
2021-04-20  9:23                 ` Xionghu Luo
2021-04-21 11:54                   ` Richard Biener
2021-05-14  7:10                     ` Xionghu Luo
2021-05-17  8:11                       ` Richard Biener
2021-05-18  5:20                         ` [PATCH] Run pass_sink_code once more before store_mergin Xionghu Luo
2021-05-18  7:02                           ` Richard Biener
2021-05-18  9:00                             ` Xionghu Luo
2021-05-18 10:34                               ` Richard Biener
2021-05-19  8:03                                 ` Bernd Edlinger
2021-09-02 15:45                           ` Martin Jambor [this message]
2021-04-24  3:44             ` [RFC] Run pass_sink_code once more after ivopts/fre Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ri6tuj37zhd.fsf@suse.cz \
    --to=mjambor@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=luoxhu@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).