From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 10694385B835 for ; Thu, 9 Apr 2020 17:46:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 10694385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mjambor@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "Cc" Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 44463AD63; Thu, 9 Apr 2020 17:46:07 +0000 (UTC) From: Martin Jambor To: Jakub Jelinek , Tobias Burnus Cc: gcc-patches Cc: Subject: Re: [Patch] HSA: omp-grid.c =?utf-8?Q?=E2=80=93?= access proper clause code (was: Re: [Patch] omp-grid.c =?utf-8?Q?=E2=80=93?= add cast to silence different enumeration types warning) In-Reply-To: <20200406123212.GS2212@tucnak> References: <449b24ed-5395-1050-4c31-4a17807688cc@codesourcery.com> <20200403090800.GY2212@tucnak> <3b3992ae-4e3a-42ad-cdd7-7998bd8dbbe4@codesourcery.com> <20200406123212.GS2212@tucnak> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-suse-linux-gnu) Date: Thu, 09 Apr 2020 19:46:07 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3054.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2020 17:46:10 -0000 Hi, On Mon, Apr 06 2020, Jakub Jelinek wrote: > On Fri, Apr 03, 2020 at 12:43:42PM +0200, Tobias Burnus wrote: >> HSA: omp-grid.c =E2=80=93 access proper clause code >>=20 >> * omp-grid.c (grid_eliminate_combined_simd_part): Use >> OMP_CLAUSE_CODE to access the omp clause code. >>=20 >> diff --git a/gcc/omp-grid.c b/gcc/omp-grid.c >> index b98e45de6a0..ba635fd3ea2 100644 >> --- a/gcc/omp-grid.c >> +++ b/gcc/omp-grid.c >> @@ -1065,7 +1065,7 @@ grid_eliminate_combined_simd_part (gomp_for *parlo= op) >> while (*pc) >> { >> tree c =3D *pc; >> - switch (TREE_CODE (c)) >> + switch (OMP_CLAUSE_CODE (c)) >> { >> case OMP_CLAUSE_LINEAR: >> { > > It looks good to me, but I have no way to actually test it, nor understand > why it worked (or isn't covered by testsuite) in the HSAIL offloading cas= e. > Martin? > Yes, most likely the gridification of any tests which should have covered this bailed out earlier. The patch looks obvious to me. Thanks for taking care of it. Martin