From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 71BCA382D3E6 for ; Wed, 14 Dec 2022 14:06:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 71BCA382D3E6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 34A6A2008A; Wed, 14 Dec 2022 14:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1671026770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cx/Fsd8rMQZiFQ+mM3ITrj6OpKv6V14GxQV4ChehQr8=; b=ipOm6JlAyr9DkoZdq3IQCalg0wsdynQCN8z5f70pZj/Tgla2QbCdHynOLk+M95lgmG7KGk Iw6Q3t7XHnKHB4yOtCjleh9/d3D47tscOxtjs3mWMh/KUoEUfcrxoYeVVRnUrsPMkHisnd RqqGb10mrpfbOxSkMK25uKR3AWYUdMM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1671026770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cx/Fsd8rMQZiFQ+mM3ITrj6OpKv6V14GxQV4ChehQr8=; b=sB+ZySsdT20RzDOzQOFuyG8RI0dd6Akm4mGm8un4YezIhE/aS6Tebe8SuIuNkFoxWoEbT+ 5tK4jlpHIVykhTCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28085138F6; Wed, 14 Dec 2022 14:06:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4NW5CVLYmWOtGwAAMHmgww (envelope-from ); Wed, 14 Dec 2022 14:06:10 +0000 From: Martin Jambor To: Martin =?utf-8?Q?Li=C5=A1ka?= , gcc-patches@gcc.gnu.org Cc: Subject: Re: [PATCH (pushed)] docs: document --param=ipa-sra-ptrwrap-growth-factor In-Reply-To: <116bcbd3-f5f9-4219-953e-4ec9cef3c457@suse.cz> References: <116bcbd3-f5f9-4219-953e-4ec9cef3c457@suse.cz> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.1 (x86_64-suse-linux-gnu) Date: Wed, 14 Dec 2022 15:06:09 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Wed, Dec 14 2022, Martin Li=C5=A1ka wrote: > gcc/ChangeLog: > > * doc/invoke.texi: Document ipa-sra-ptrwrap-growth-factor. Thanks or spotting this. Seeing the email also averted me to the fact that what I wrote in the parameter description is almost the opposite of what it should say. I'll fix that momentarily with the following patch. Thanks again, Martin Somehow I made the description of the parameter almost the opposite of what I wanted to say. Fixed by this patch. Tested by building gcc on x86_64-linux and make info and make pdf. gcc/ChangeLog: 2022-12-14 Martin Jambor * doc/invoke.texi (ipa-sra-ptrwrap-growth-factor): Fix the description. * params.opt (ipa-sra-ptrwrap-growth-factor): Likewise. --- gcc/doc/invoke.texi | 3 ++- gcc/params.opt | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 7dc1d45e275..f48df64cc2a 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -15523,7 +15523,8 @@ pointer parameter. @item ipa-sra-ptrwrap-growth-factor Additional maximum allowed growth of total size of new parameters that ipa-sra replaces a pointer to an aggregate with, -if it points to a local variable that the caller never writes to. +if it points to a local variable that the caller only writes to and +passes it as an argument to other functions. =20 @item ipa-sra-max-replacements Maximum pieces of an aggregate that IPA-SRA tracks. As a diff --git a/gcc/params.opt b/gcc/params.opt index e0fd05fb44a..e0380bf10f9 100644 --- a/gcc/params.opt +++ b/gcc/params.opt @@ -296,7 +296,7 @@ Maximum allowed growth of total size of new parameters = that ipa-sra replaces a p =20 -param=3Dipa-sra-ptrwrap-growth-factor=3D Common Joined UInteger Var(param_ipa_sra_ptrwrap_growth_factor) Init(4) In= tegerRange(1, 8) Param Optimization -Additional maximum allowed growth of total size of new parameters that ipa= -sra replaces a pointer to an aggregate with, if it points to a local varia= ble that the caller never writes to. +Additional maximum allowed growth of total size of new parameters that ipa= -sra replaces a pointer to an aggregate with, if it points to a local varia= ble that the caller only writes to and passes it as an argument to function= s. =20 -param=3Dira-loop-reserved-regs=3D Common Joined UInteger Var(param_ira_loop_reserved_regs) Init(2) Param Opt= imization --=20 2.38.1