From: Martin Jambor <mjambor@suse.cz>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jan Hubicka <jh@suse.cz>, Jan Hubicka <hubicka@ucw.cz>
Subject: [PATCH 8/9] ipa-sra: Make scan_expr_access bail out on uninteresting expressions
Date: Mon, 12 Dec 2022 17:53:48 +0100 [thread overview]
Message-ID: <ri6wn6wh8bn.fsf@suse.cz> (raw)
Hi,
I'm re-posting patches which I have posted at the end of stage 1 but
which have not passed review yet.
8<--------------------------------------------------------------------
I have noticed that scan_expr_access passes all the expressions it
gets to get_ref_base_and_extent even when we are really only
interested in memory accesses. So bail out when the expression is
something clearly uninteresting.
Bootstrapped and tested individually when I originally posted it and
now bootstrapped and LTO-bootstrapped and tested as part of the whole
series. OK for master?
gcc/ChangeLog:
2021-12-14 Martin Jambor <mjambor@suse.cz>
* ipa-sra.c (scan_expr_access): Bail out early if expr is something we
clearly do not need to pass to get_ref_base_and_extent.
---
gcc/ipa-sra.cc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc
index 93fceeafc73..3646d71468c 100644
--- a/gcc/ipa-sra.cc
+++ b/gcc/ipa-sra.cc
@@ -1748,6 +1748,11 @@ scan_expr_access (tree expr, gimple *stmt, isra_scan_context ctx,
|| TREE_CODE (expr) == REALPART_EXPR)
expr = TREE_OPERAND (expr, 0);
+ if (!handled_component_p (expr)
+ && !DECL_P (expr)
+ && TREE_CODE (expr) != MEM_REF)
+ return;
+
base = get_ref_base_and_extent (expr, &poffset, &psize, &pmax_size, &reverse);
if (TREE_CODE (base) == MEM_REF)
--
2.38.1
next reply other threads:[~2022-12-12 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 16:53 Martin Jambor [this message]
2022-12-12 21:56 ` Jan Hubicka
2022-12-12 21:58 ` Jan Hubicka
2022-12-13 8:40 ` Richard Biener
2022-12-13 12:53 ` Richard Biener
2022-12-14 13:20 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ri6wn6wh8bn.fsf@suse.cz \
--to=mjambor@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jh@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).