From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 863AA3858C39 for ; Fri, 14 Oct 2022 11:59:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 863AA3858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 70EA321F4A; Fri, 14 Oct 2022 11:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1665748755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XsHvJnyGxsVk+kkmxyt2L7aZfewbpohC0BlklsJMqCQ=; b=CYALYR8P7hwtwkJVRtzvdmvdfpiL6CKT0v2y0VilXGoYRBOC+PmyNG6znxaG/veHphAw2h OEHXGmNtVoc5G1MhfrI9CduRiCDfbC0i7vftgn7H/5znaqcANLoOFon+nzydlsOpDy9YS1 dW91EYMtETB0Yzpfo3yAg/8Tk5pkynQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1665748755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XsHvJnyGxsVk+kkmxyt2L7aZfewbpohC0BlklsJMqCQ=; b=t8V2SYR6hg4qq+eaE4k1TnHc18z7CsYWccx1OK/n3mwUAXZtGNkKGJXj1PZq/EeoXjb+t3 ziP++7FuUOOYbuDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 643B013451; Fri, 14 Oct 2022 11:59:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sQZtGBNPSWNEdgAAMHmgww (envelope-from ); Fri, 14 Oct 2022 11:59:15 +0000 From: Martin Jambor To: Martin =?utf-8?Q?Li=C5=A1ka?= , Richard Biener , Eric Botcazou Cc: Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix bogus -Wstringop-overflow warning In-Reply-To: References: <3194055.aeNJFYEL58@fomalhaut> <1908968.PYKUYFuaPT@fomalhaut> User-Agent: Notmuch/0.35 (https://notmuchmail.org) Emacs/28.1 (x86_64-suse-linux-gnu) Date: Fri, 14 Oct 2022 13:59:15 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Fri, Oct 14 2022, Martin Li=C5=A1ka wrote: > On 10/14/22 08:12, Richard Biener wrote: >> On Fri, Oct 14, 2022 at 12:54 AM Eric Botcazou via Gcc-patches >> wrote: >>> >>>> Not a fan as it could potentially hide a real issue, but I don't really >>>> have a better solution. >>> >>> Thanks. >>> >>>> I pondered suggesting "access" affect type identity, but the cases whe= re >>>> that's really important are probably better handled by the "fn spec" >>>> attribute, leaving "access" strictly impacting diagnostics. >>> >>> I can expand a bit here, because I tried to change the "access" attribu= te that >>> way and this badly breaks the C compiler, for example: >>> >>> int foo (int n, char m[1][n]); >>> >>> int foo (int n, char m[1][n]) {} >>> >>> no longer compiles with an error about different function types. >>=20 >> Note in discussion with IPA folks we agreed that IPA cloning that modifi= es >> arguments either has to remove access attributes, adjust them or refrain >> from cloning. >>=20 >> Martin - has anything been done to this respect? > > I think it's more for Martin Jambor who's the IPA specialist when it comes > to parameter manipulation. > They are being dropped since 2af63f0f53a Adjusting them accordingly is an item buried quite deep in my TODO list. >>=20 >> I suppose there's also a way to figure if a clone has arguments >> changed in any way? Look whether clone_info::get (node) exists and its param_adjustments is non-NULL. In theory the param_adjustments could contain description of the very same signature the original function has but in practice it does not currently happen and is unlikely to happen ever. Martin