From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 1F0553858D3C for ; Fri, 16 Jun 2023 10:26:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F0553858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4ADA01FDEF; Fri, 16 Jun 2023 10:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686911184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yujA37nVXX3uFRpFr5T2PV4B4ldETdyJJLemEhI1vD8=; b=iocZ4XG6Xr/gESQFYRhBDeJkwSFFQBqhTAmbV6PWu5nPN7hQHFy7yeGM09JxWiIDhFvVld J9gtOdFcbRe2UmfiYTQ5GX4dAv/Tq0WuLc9SCGOerSFi+4Ma3ItjMNIbZQu+WaTPmJLMOY 9hHA5Hf1HyS0PvCgcAu+tMEhsVQ48NI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686911184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yujA37nVXX3uFRpFr5T2PV4B4ldETdyJJLemEhI1vD8=; b=yi3/HwK5ZbTe92hv20M1xs9K3e/o6Iu3rVW8P/pmAKGNjSlNWgQo9O9zTlHmWAih9dHRu8 GKbX6jRajpt7RQBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3ED981330B; Fri, 16 Jun 2023 10:26:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JM5SD9A4jGS0aAAAMHmgww (envelope-from ); Fri, 16 Jun 2023 10:26:24 +0000 From: Martin Jambor To: Marek Polacek Cc: GCC Patches Subject: Re: [PATCH v3] configure: Implement --enable-host-pie In-Reply-To: References: <20230509194158.329137-1-polacek@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.2 (x86_64-suse-linux-gnu) Date: Fri, 16 Jun 2023 12:26:23 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Thu, Jun 15 2023, Marek Polacek via Gcc-patches wrote: > On Mon, Jun 05, 2023 at 09:06:43PM -0600, Jeff Law wrote: >> >> >> On 6/5/23 10:18, Marek Polacek via Gcc-patches wrote: >> > Ping. Anyone have any further comments? >> Given this was approved before, but got reverted due to issues (which have >> since been addressed) -- I think you might as well go forward and sooner >> rather than later so that we can catch fallout earlier. > > Thanks, pushed now, after rebasing, adjusting the patch for > r14-1385, and testing with and without --enable-host-pie on > both Debian and Fedora. > > If something comes up and I can't fix it quickly enough, I'll > have to revert the patch. We'll see. > The script that regularly checks that the checked-in autotools-generated files are in sync now complain about the following diff. Unless someone stops me because I overlooked something or for some other reason, I will commit it later on as obvious. I wonder where the "line" differences come from, perhaps you added a comment after running autoconf/automake/...? The zlib/Makefile.in hunks like something we should have, though, even if I did not check whether it makes any difference in practice. And I want the checking script to shut up too ;-) Thanks, Martin diff --git a/gcc/configure b/gcc/configure index a4563a9cade..f7b4b283ca2 100755 --- a/gcc/configure +++ b/gcc/configure @@ -19847,7 +19847,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 19848 "configure" +#line 19850 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -19953,7 +19953,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 19954 "configure" +#line 19956 "configure" #include "confdefs.h" #if HAVE_DLFCN_H diff --git a/zlib/Makefile.in b/zlib/Makefile.in index 3f5102d1b87..80fe3b69116 100644 --- a/zlib/Makefile.in +++ b/zlib/Makefile.in @@ -353,6 +353,8 @@ datadir = @datadir@ datarootdir = @datarootdir@ docdir = @docdir@ dvidir = @dvidir@ +enable_host_pie = @enable_host_pie@ +enable_host_shared = @enable_host_shared@ exec_prefix = @exec_prefix@ host = @host@ host_alias = @host_alias@ diff --git a/zlib/configure b/zlib/configure index 77be6c284e3..9308866a636 100755 --- a/zlib/configure +++ b/zlib/configure @@ -10763,7 +10763,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 10778 "configure" +#line 10766 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -10869,7 +10869,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 10884 "configure" +#line 10872 "configure" #include "confdefs.h" #if HAVE_DLFCN_H