From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 1A2D63858D20 for ; Wed, 31 Jan 2024 12:18:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A2D63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A2D63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706703532; cv=none; b=YcxqZbFKk5+e1p4DdRVfPVeczjj7tU6EO9YvNBAZy8hZIWzkeHwREHmTT6g/8CzJ60JHGIvuMWF46l0X+RbMwTojcEMtfA2YYAMaRNwL9B2QbqzzRUnHPYJ2qi6t8ThLZE24/0fFnvph6U8hv6B3Q/UOJUv0VjqGO3siLUnux+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706703532; c=relaxed/simple; bh=7HAnmJlnkJ+Gue4plDeEGWlnbQw8caSaJDWKiDIS3So=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=AJQ7kUtYr7ISf19qS7uCqvsrctU9YASGQu9gQemV1Bh1d0f0MbDd2cAFxAxAKoC7TwEebyYg5IwWUyTZCuzSYgk0Y9kZLk+JgmZSqBtjZZjhPTXbh+iMfUAverhPbTVhD/cyPMm21OI6ike2tWben6MUrA4q4J1IN2mNPp6MC4U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 318281FD12; Wed, 31 Jan 2024 12:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706703530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/Jx5JaFPtMah6Q3Hw7Fm4dyxz5sxNVni9BYQB0Gz+I=; b=qidU0OKNLvnsSROU0QhWBj51S3SRWFVlQRRYYm9APcWsNMSk0HLPZTZYQpZ3oIgOc1QkkF 4OeDkgbbf44pQl8iYT01fvHyiaVHERpljqUNMXyCwKVV6y4HM6h2RGAF+SYDj7FEl2BEzf 7CP4aglJDmzAvXQ62aHOk9XgtSqkr1o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706703530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/Jx5JaFPtMah6Q3Hw7Fm4dyxz5sxNVni9BYQB0Gz+I=; b=GH5xBpMCJlMW4muSbQvddQ9uUSLutx93SohCbYlkZ173vbTPkbrrkTWGV5rcv7ODNsArnl iK2MhoF60e0Gb3Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706703530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/Jx5JaFPtMah6Q3Hw7Fm4dyxz5sxNVni9BYQB0Gz+I=; b=qidU0OKNLvnsSROU0QhWBj51S3SRWFVlQRRYYm9APcWsNMSk0HLPZTZYQpZ3oIgOc1QkkF 4OeDkgbbf44pQl8iYT01fvHyiaVHERpljqUNMXyCwKVV6y4HM6h2RGAF+SYDj7FEl2BEzf 7CP4aglJDmzAvXQ62aHOk9XgtSqkr1o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706703530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C/Jx5JaFPtMah6Q3Hw7Fm4dyxz5sxNVni9BYQB0Gz+I=; b=GH5xBpMCJlMW4muSbQvddQ9uUSLutx93SohCbYlkZ173vbTPkbrrkTWGV5rcv7ODNsArnl iK2MhoF60e0Gb3Bg== Date: Wed, 31 Jan 2024 13:13:12 +0100 (CET) From: Richard Biener To: Andre Vieira cc: gcc-patches@gcc.gnu.org, Richard.Sandiford@arm.com Subject: Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE In-Reply-To: Message-ID: References: <20240130143132.9575-1-andre.simoesdiasvieira@arm.com> <20240130143132.9575-2-andre.simoesdiasvieira@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -1.22 X-Spamd-Result: default: False [-1.22 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.11)[-0.572]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.01)[45.25%] X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 31 Jan 2024, Richard Biener wrote: > On Tue, 30 Jan 2024, Andre Vieira wrote: > > > > > This patch adds stmt_vec_info to TARGET_SIMD_CLONE_USABLE to make sure the > > target can reject a simd_clone based on the vector mode it is using. > > This is needed because for VLS SVE vectorization the vectorizer accepts > > Advanced SIMD simd clones when vectorizing using SVE types because the simdlens > > might match. This will cause type errors later on. > > > > Other targets do not currently need to use this argument. > > Can you instead pass down the mode? Thinking about that again the cgraph_simd_clone info in the clone should have sufficient information to disambiguate. If it doesn't then we should amend it. Richard.