From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 68FA23858CDB for ; Mon, 5 Feb 2024 08:59:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68FA23858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68FA23858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707123567; cv=none; b=xJCm870UPKmrPWX/oJGzAf5Qq5sREW7AY0sN2uovoPTGOtiDq8yFMq9h8mWzhy45/rYfawFTqes36UbS+ioUIPCWyfbpasweIyjPVeuZ5aswwdAydTRvEnZTBCUFKHRusq8fQYeGgSGP7ZtPKgY/ZkhVyFP0vA4vf7UbgOuru8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707123567; c=relaxed/simple; bh=4XFtrtaPcJU7yLKXLsvavN3U0bI1p7pc5qFgXljMjgc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=Mxn8i0jlBo/qSlU/vv1LCmZvWdiSCMu+8jhHI8HrbhBR1JvgTjem5/mgVe+/nCnRGd0LUQLFW702FV/b+0PuolpgaCR/3bRJ41rAtqvKrCBI7yQAimAf/Yvgd6N9irWTssjDTuEt+0gcUuwVSmNsuDOlCo8b8YKPOCooX9RY9M8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5976F222AC; Mon, 5 Feb 2024 08:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707123564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nh86uqh31LGv2pQgB16lW5YgtyMw5rG7jsbykVDL+OY=; b=FJijYHmhTWtwXVxaTuWmIIAHPR9oeTWPnqY7mdmUe/Nd4ziI12Brn9plTFZqMmNJTv4wxD Y+TBroMeyggcczVO+ps2Syv/t5RRy2RSZcBrz+m0mkYMPUPVtgSnkGsUllPPMglPG7JhkB SIttptCtNyVo2Exy/AHQIYuidbw9gFc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707123564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nh86uqh31LGv2pQgB16lW5YgtyMw5rG7jsbykVDL+OY=; b=kiw6mihnRqoqkqb+IwIhFodtEgIQgywnb1N2yG/HHDZ68Wkg4PnMcHufo6evC4rHglEV8F IU8/kXtcDUzsDfDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707123564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nh86uqh31LGv2pQgB16lW5YgtyMw5rG7jsbykVDL+OY=; b=FJijYHmhTWtwXVxaTuWmIIAHPR9oeTWPnqY7mdmUe/Nd4ziI12Brn9plTFZqMmNJTv4wxD Y+TBroMeyggcczVO+ps2Syv/t5RRy2RSZcBrz+m0mkYMPUPVtgSnkGsUllPPMglPG7JhkB SIttptCtNyVo2Exy/AHQIYuidbw9gFc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707123564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nh86uqh31LGv2pQgB16lW5YgtyMw5rG7jsbykVDL+OY=; b=kiw6mihnRqoqkqb+IwIhFodtEgIQgywnb1N2yG/HHDZ68Wkg4PnMcHufo6evC4rHglEV8F IU8/kXtcDUzsDfDA== Date: Mon, 5 Feb 2024 09:59:24 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] lower-bitint: Remove single label _BitInt switches [PR113737] In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -3.10 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 5 Feb 2024, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs, because group_case_labels_stmt optimizes > switch (a.0_7) [50.00%], case 0: [50.00%], case 2: [50.00%]> > where L7 block starts with __builtin_unreachable (); to > switch (a.0_7) [50.00%]> > and single label GIMPLE_SWITCH is something the switch expansion refuses to > lower: > if (gimple_switch_num_labels (m_switch) == 1 > || range_check_type (index_type) == NULL_TREE) > return false; > (range_check_type never returns NULL for BITINT_TYPE), but the gimple > lowering pass relies on all large/huge _BitInt switches to be lowered > by that pass. > > The following patch just removes those after making the single successor > edge EDGE_FALLTHRU. I've done it even if !optimize just in case in case > we'd end up with single case label from earlier passes. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK. Richard. > 2024-02-05 Jakub Jelinek > > PR tree-optimization/113737 > * gimple-lower-bitint.cc (gimple_lower_bitint): If GIMPLE_SWITCH > has just a single label, remove it and make single successor edge > EDGE_FALLTHRU. > > * gcc.dg/bitint-84.c: New test. > > --- gcc/gimple-lower-bitint.cc.jj 2024-02-02 11:30:05.801776658 +0100 > +++ gcc/gimple-lower-bitint.cc 2024-02-03 12:49:52.997777574 +0100 > @@ -5832,7 +5832,14 @@ gimple_lower_bitint (void) > > if (optimize) > group_case_labels_stmt (swtch); > - switch_statements.safe_push (swtch); > + if (gimple_switch_num_labels (swtch) == 1) > + { > + single_succ_edge (bb)->flags |= EDGE_FALLTHRU; > + gimple_stmt_iterator gsi = gsi_for_stmt (swtch); > + gsi_remove (&gsi, true); > + } > + else > + switch_statements.safe_push (swtch); > } > } > > --- gcc/testsuite/gcc.dg/bitint-84.c.jj 2024-02-03 12:56:08.153622744 +0100 > +++ gcc/testsuite/gcc.dg/bitint-84.c 2024-02-03 12:57:05.425835789 +0100 > @@ -0,0 +1,32 @@ > +/* PR tree-optimization/113737 */ > +/* { dg-do compile { target bitint } } */ > +/* { dg-options "-O2 -std=c23" } */ > + > +#if __BITINT_MAXWIDTH__ >= 129 > +_BitInt(129) a; > +#else > +_BitInt(63) a; > +#endif > + > +int b[1], c; > + > +int > +foo (void) > +{ > + switch (a) > + case 0: > + case 2: > + return 1; > + return 0; > +} > + > +void > +bar (int i) > +{ > + for (;; ++i) > + { > + c = b[i]; > + if (!foo ()) > + __asm__ (""); > + } > +} > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)