From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 188D23858C2F for ; Wed, 31 Jan 2024 12:17:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 188D23858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 188D23858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706703427; cv=none; b=tWBeTjDFqXull4IvlhdyQfCBFglvrpFcBhIhp5ELTIou+MkC4XZXHTyYVuZjrAj0hKhcVmZwrJFsYTQbh7NsVrzs+sKr6ROqT/Wzm6ZeGPVdZigwY0flVbew96c8953ERqzbHMnFumI0mVw/YmqEFYDMuyWOvrTi1JrdJxb3pVg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706703427; c=relaxed/simple; bh=6oUzF1ICA2QbCXEeQLEbJbyKEphBxOlkz74WsLVKvNw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=p3hkCM3PIJeSu2MRWUZcXH9uT5yedlscZ/JQJeXt0f8vO3sZac8tV1ZuOi11+PYdH94Aunn27W4m9oBJQSWUePeE/f5ebzBKDCxmQxT5O/9Gw3kYnj1kFhsU27idyghQ1XG2p6yxQucSCJvx0DFUGL8CzRcRZZaw1Ed+Q4dACIA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 09A7C21EF9; Wed, 31 Jan 2024 12:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706703424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WSFDUkNAmGRuVoVURPINCb7JxZRjH31HbioKdH0e4ZE=; b=V2XaL56ljun8j2Lf9gczBIFipYP3NBTiPUQtB3L+xig07tRNsyzNJxxT4Jh7tTqUrAkMzf IOWTtCB4TOki9YNl5XgJV2AD8JFF68G7TTtivkBGKH/cV6RrXDUiH3X36UN5Jx8t5aLsmn pmdBbroecrVpXDm4emVbAaVtq1DGna8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706703424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WSFDUkNAmGRuVoVURPINCb7JxZRjH31HbioKdH0e4ZE=; b=iO7PssGOqxhFKV4GIFzJnZ1ku3lRS7kbE5bXvX9kLKUIO1FcKfrw7B/2zVK3WeQTQkiTKP YttxuhUwbyAMCQAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706703424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WSFDUkNAmGRuVoVURPINCb7JxZRjH31HbioKdH0e4ZE=; b=V2XaL56ljun8j2Lf9gczBIFipYP3NBTiPUQtB3L+xig07tRNsyzNJxxT4Jh7tTqUrAkMzf IOWTtCB4TOki9YNl5XgJV2AD8JFF68G7TTtivkBGKH/cV6RrXDUiH3X36UN5Jx8t5aLsmn pmdBbroecrVpXDm4emVbAaVtq1DGna8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706703424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WSFDUkNAmGRuVoVURPINCb7JxZRjH31HbioKdH0e4ZE=; b=iO7PssGOqxhFKV4GIFzJnZ1ku3lRS7kbE5bXvX9kLKUIO1FcKfrw7B/2zVK3WeQTQkiTKP YttxuhUwbyAMCQAA== Date: Wed, 31 Jan 2024 13:11:26 +0100 (CET) From: Richard Biener To: Andre Vieira cc: gcc-patches@gcc.gnu.org, Richard.Sandiford@arm.com Subject: Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE In-Reply-To: <20240130143132.9575-2-andre.simoesdiasvieira@arm.com> Message-ID: References: <20240130143132.9575-1-andre.simoesdiasvieira@arm.com> <20240130143132.9575-2-andre.simoesdiasvieira@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.30 X-Spamd-Result: default: False [-1.30 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.19)[-0.957]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.01)[46.83%] X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 30 Jan 2024, Andre Vieira wrote: > > This patch adds stmt_vec_info to TARGET_SIMD_CLONE_USABLE to make sure the > target can reject a simd_clone based on the vector mode it is using. > This is needed because for VLS SVE vectorization the vectorizer accepts > Advanced SIMD simd clones when vectorizing using SVE types because the simdlens > might match. This will cause type errors later on. > > Other targets do not currently need to use this argument. Can you instead pass down the mode? > gcc/ChangeLog: > > * target.def (TARGET_SIMD_CLONE_USABLE): Add argument. > * tree-vect-stmts.cc (vectorizable_simd_clone_call): Pass stmt_info to > call TARGET_SIMD_CLONE_USABLE. > * config/aarch64/aarch64.cc (aarch64_simd_clone_usable): Add argument > and use it to reject the use of SVE simd clones with Advanced SIMD > modes. > * config/gcn/gcn.cc (gcn_simd_clone_usable): Add unused argument. > * config/i386/i386.cc (ix86_simd_clone_usable): Likewise. > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)