From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) by sourceware.org (Postfix) with ESMTPS id 562A23858D1E for ; Thu, 19 Oct 2023 21:31:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 562A23858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=protonmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 562A23858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.70.40.133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697751084; cv=none; b=mTrs8Cz5wEn69BIW+mb3djsOCoq6dtGIEoLiW6ZP/ECOJY0cHxFXYOwMyWrywFP2QV6Z/Wdu1rEpasqtwuFTZSPxb7Mbc5TfGY8tnnty7GKFLhiJx+VMTNHm/ZwgeIHD2wpc9R4KCXcndBI5VvJEczOSweWyFO2bYO5OS28xPz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697751084; c=relaxed/simple; bh=hOJRBMlnvDeCHyESdcA04ylyf+KuwJLEXf3/DlI/8xs=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=UffdeqRSJ30w5j5pjGhHmKFim8ZuZ1Kji5pV3CgDRS1+atk9hneI81N5VWbwEZujaD/jpBh6766wjIJh2iGsckJwDhao6G05qoMCMgXyZs0MBa9iB6yuS2QhtCckjCkC68McbrCHVvm4NJ7puSpRml+8FUO0q1GI3DP86Cry6WQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1697751081; x=1698010281; bh=hOJRBMlnvDeCHyESdcA04ylyf+KuwJLEXf3/DlI/8xs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=yBSwRMKPocJjII2xSwlr4aDS/OWbKfeC8CmxEbPHqfrYDULxt1AUUo3QgCLfSpUsu As6Iy6q9qSNiy+e4gpVgJ76rjhTLSeFBTXuHq3ZoxeaIpge0D4x3VPNvfSCyxjCJlD D5VGqMotPldtG6gimeMEeHHSoT/vrXToIuqc+mrvXi7jX/TyNLb1PCvLp+5DUx4u06 9K2677KVN0mrAFNYrTT3K+fd2MmsMfhhw36L8eeC86tsXOVeC4ojDTDhOA+bTihBg8 hgNXUu4wwPXrGyejw+Qx5BgmHqcMW4jiEGiZ2mNnfOGJjP00nicdZ/fQ3+uJr1+xsb ZxXTnYIKsRvIg== Date: Thu, 19 Oct 2023 21:31:06 +0000 To: Jakub Jelinek From: waffl3x Cc: Jason Merrill , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH v3 1/2] c++: Initial support for P0847R7 (Deducing This) [PR102609] Message-ID: In-Reply-To: References: <0cc5b21d-4b27-4964-bec3-544c86307c74@redhat.com> Feedback-ID: 14591686:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > No, that wouldn't be appropriate for translation. > None of non-member, static member and explicit object member are > something that should be printed verbatim untranslated. > "%s function %qD cannot have cv-qualifier", _("non-member") > etc. is still inappropriate, some language might need to reorder > the words in one case and not another one etc. > > What is ok if that %s (but in that case better %qs) is say some > language keyword which shouldn't be translated. > > "%qs keyword not expected" > with > the arg being "inline", "constexpr", "consteval" for example would > be fine. > > Jakub Ah alright, I see what you're saying, I see what the difference is now. It's a shame we can't have the translated string insert a %s and format into that :^). Ah well, I guess this code is just doomed to look poor then, what can you do. This is pretty much why I've been afraid to touch anything with these macros, if I don't understand exactly how it works anything slightly weird solution I use might just not work. Anyway, I think that clears up everything regarding that now, thanks. Alex