From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 853EB385E44A for ; Mon, 19 Jul 2021 12:21:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 853EB385E44A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 73437222DA for ; Mon, 19 Jul 2021 12:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626697293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=2jbFuKevaHq6m2XXGiE/3liyq9VuM19FdWwNMS2lkH4=; b=eqa4qu4Z/Rb/Ujg0rEoqHmcUIkQ7C/lx8cWMGGCgP+9uyWACEBTSF6n5WbITrqRkcFboRp jQu1F96ykIGg4F4eFkf+iLScGHKzGOvVTuDayM4mSXkjcn52Ncsrhfv7695hD5WCNKw5VL riN8jV4J2Wi2hS0JtC0tReFosWvxG7Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626697293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=2jbFuKevaHq6m2XXGiE/3liyq9VuM19FdWwNMS2lkH4=; b=Ufo7J3tXfYI1LYs4HQ64fb78gciCLRfINNBwbsDkEUFCyUsq04Znd7X4TqNOjcki2nLEJc eQ5UKrxb4qVnjWDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6039013CE9 for ; Mon, 19 Jul 2021 12:21:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cmVeFk1u9WAkYAAAMHmgww (envelope-from ) for ; Mon, 19 Jul 2021 12:21:33 +0000 Date: Mon, 19 Jul 2021 14:21:33 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/101505 - properly determine stmt precision for PHIs Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 12:21:35 -0000 Loop vectorization pattern recog fails to walk PHIs when determining stmt precisions. This fails to recognize non-mask uses for bools in PHIs and outer loop vectorization. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-07-19 Richard Biener PR tree-optimization/101505 * tree-vect-patterns.c (vect_determine_precisions): Walk PHIs also for loop vectorization. * gcc.dg/vect/pr101505.c: New testcase. --- gcc/testsuite/gcc.dg/vect/pr101505.c | 16 ++++++++++++++++ gcc/tree-vect-patterns.c | 14 ++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/vect/pr101505.c diff --git a/gcc/testsuite/gcc.dg/vect/pr101505.c b/gcc/testsuite/gcc.dg/vect/pr101505.c new file mode 100644 index 00000000000..e2b8945a5cc --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr101505.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-O1" } */ + +int n2; + +__attribute__ ((simd)) char +w7 (void) +{ + short int xb = n2; + int qp; + + for (qp = 0; qp < 2; ++qp) + xb = xb < 1; + + return xb; +} diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c index c2494446183..44f6c9b2bd6 100644 --- a/gcc/tree-vect-patterns.c +++ b/gcc/tree-vect-patterns.c @@ -5355,6 +5355,13 @@ vect_determine_precisions (vec_info *vinfo) for (unsigned int i = 0; i < nbbs; i++) { basic_block bb = bbs[i]; + for (auto gsi = gsi_start_phis (bb); + !gsi_end_p (gsi); gsi_next (&gsi)) + { + stmt_vec_info stmt_info = vinfo->lookup_stmt (gsi.phi ()); + if (stmt_info) + vect_determine_mask_precision (vinfo, stmt_info); + } for (auto si = gsi_start_bb (bb); !gsi_end_p (si); gsi_next (&si)) if (!is_gimple_debug (gsi_stmt (si))) vect_determine_mask_precision @@ -5368,6 +5375,13 @@ vect_determine_precisions (vec_info *vinfo) if (!is_gimple_debug (gsi_stmt (si))) vect_determine_stmt_precisions (vinfo, vinfo->lookup_stmt (gsi_stmt (si))); + for (auto gsi = gsi_start_phis (bb); + !gsi_end_p (gsi); gsi_next (&gsi)) + { + stmt_vec_info stmt_info = vinfo->lookup_stmt (gsi.phi ()); + if (stmt_info) + vect_determine_stmt_precisions (vinfo, stmt_info); + } } } else -- 2.26.2