From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id BA6423858C2A for ; Thu, 7 Dec 2023 01:30:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA6423858C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA6423858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701912659; cv=none; b=MypG2+LWy3eEjroehGx5JcC052wcVo3eOJ/jopYxsxm5C2Bx09qVNPzGuAqMH9/+X8WbM+Kyr2K4c8P9OinEck4kI+tT01ANbxPeQvfl7X/cPRviFwMszdJidSxcUtnItJm06/VP7UccNZUu9rDoQSmOip+HtKrOW2JYxl/0H6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701912659; c=relaxed/simple; bh=o3IqbEHlbZP7X4KZPGO+2h86Ju/THD1eR8CGgCF/+bw=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=Zx8me+rzXGcl07tE4wxErtXdkyOSSLx1kksB0WPOWZ47ek3ZK02pxnUommEk0t/KzQtHaxBO6nVs9iEBtAEWF0Io8OMzfYZD9E0qDslbLSqRjXa+ZIpCgc75VS/sjYLy/FkmYAi1MXkyjjpbMFq1YvkgRrfGnh446p1FE+XLsdw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rB3E3-0006Wy-R7 for gcc-patches@gcc.gnu.org; Wed, 06 Dec 2023 20:30:57 -0500 Received: from loongson.cn (unknown [114.243.111.185]) by gateway (Coremail) with SMTP id _____8Dxl+hAIHFlSnw_AA--.25279S3; Thu, 07 Dec 2023 09:30:40 +0800 (CST) Received: from rescuer (unknown [114.243.111.185]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxDt08IHFllQpXAA--.9847S2; Thu, 07 Dec 2023 09:30:37 +0800 (CST) Date: Thu, 7 Dec 2023 09:30:32 +0800 From: Yang Yujie To: Jeff Law Cc: Florian Weimer , Yang Yujie , gcc-patches@gcc.gnu.org, ro@cebitec.uni-bielefeld.de, mikestump@comcast.net Subject: Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types Message-ID: References: <20231206022931.33437-1-yangyujie@loongson.cn> <871qbzcyy4.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CM-TRANSID:AQAAf8DxDt08IHFllQpXAA--.9847S2 X-CM-SenderInfo: 51dqw5pxmlvqxorr0wxvrqhubq/1tbiAQARAGVv2iwI5ABjsj X-Coremail-Antispam: 1Uk129KBj93XoW7CF15ArWkur1ruw45Zw47trc_yoW8XryUpr WfXasYyrW5Xw12kwnrKa47J3WFv397Jr4kWr1Yqry2vFn093srJrWUKwn8WFZY9FW8Wr4Y qF48WF1Yqr1DZ3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUyCb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l42xK82IYc2Ij64vIr4 1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK 67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI 8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAv wI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14 v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jUsqXUUUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=yangyujie@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: > > > On 12/6/23 05:12, Florian Weimer wrote: > > * Yang Yujie: > > > > > From: Yang Yujie > > > Subject: [PATCH] testsuite: Adjust for the new permerror > > > -Wincompatible-pointer-types > > > To: gcc-patches@gcc.gnu.org > > > Cc: ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net, fweimer@redhat.com, > > > Yang Yujie > > > Date: Wed, 6 Dec 2023 10:29:31 +0800 (9 hours, 42 minutes, 7 seconds ago) > > > Message-ID: <20231206022931.33437-1-yangyujie@loongson.cn> > > > > > > r14-6037 turned -Wincompatible-pointer-types into a permerror, > > > which causes the following tests to fail. > > > > > > gcc/testsuite/ChangeLog: > > > > > > * gcc.dg/fixed-point/composite-type.c: replace dg-warning with dg-error. > > > --- > > > .../gcc.dg/fixed-point/composite-type.c | 64 +++++++++---------- > > > 1 file changed, 32 insertions(+), 32 deletions(-) > > > > Looks reasonable to me, but I can't approve it. > We might want to fix that from a policy standpoint :-) > > Regardless, this is OK for the trunk. Thanks Yang for taking care of it. I > don't see you in the maintainers file, so I'll go ahead and push it > momentarily. > > jeff Thanks for the review! With this patch, I also noticed a few errors in building unpatched older software like expect-5.45.4, perl-5.28.3 and bash-5.0. Will this also be the case when GCC 14 gets released? Thanks, Yujie