From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25965 invoked by alias); 21 Jun 2017 07:59:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24516 invoked by uid 89); 21 Jun 2017 07:59:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=our X-HELO: cc-smtpout1.netcologne.de Received: from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de) (89.1.8.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 07:59:27 +0000 Received: from cc-smtpin1.netcologne.de (cc-smtpin1.netcologne.de [89.1.8.201]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 86C001332A; Wed, 21 Jun 2017 09:59:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin1.netcologne.de (Postfix) with ESMTP id 837B011DC4; Wed, 21 Jun 2017 09:59:22 +0200 (CEST) Received: from [89.0.23.242] (helo=cc-smtpin1.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 594a275a-021e-7f0000012729-7f000001e79b-1 for ; Wed, 21 Jun 2017 09:59:22 +0200 Received: from linux-mqtz.fritz.box (xdsl-89-0-23-242.netcologne.de [89.0.23.242]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by cc-smtpin1.netcologne.de (Postfix) with ESMTPSA; Wed, 21 Jun 2017 09:59:19 +0200 (CEST) Date: Wed, 21 Jun 2017 07:59:00 -0000 From: Volker Reichelt Subject: Re: [PING] C++ Re: [PATCH] C/C++: fix quoting of "aka" typedef information (PR 62170) To: Jason Merrill cc: David Malcolm , gcc-patches List In-Reply-To: Message-ID: References: <1496689294-11629-1-git-send-email-dmalcolm@redhat.com> <1497973859.7551.171.camel@redhat.com> <1497985575.7551.179.camel@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE X-SW-Source: 2017-06/txt/msg01542.txt.bz2 On 20 Jun, Jason Merrill wrote: > On Tue, Jun 20, 2017 at 3:06 PM, David Malcolm wrote: >> It's not clear to me what the issue alluded to with negative >> obstack_blank is, but I chose to follow the above docs and use >> obstack_blank_fast; am testing an updated patch in which the above line >> now looks like: >> >> obstack_blank_fast (ob, -(type_start + type_len)); >> >> Is the patch OK with that change? (assuming bootstrap®rtesting >> pass), or should I re-post? > > OK with that change. > >> On a related matter, this patch conflicts with Volker's patch here: >> >> https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01576.html >> >> in which he removes the trailing "{enum}" info (and hence all of our >> changes to the testsuite conflict between the two patches...) >> >> Do you have any thoughts on that other patch? [Ccing Volker] > > That patch makes sense to me; I prefer "enum E" to "E {enum}". > > Jason Is 'makes sense' equivalent to 'OK for trunk' here? If so, should my patch go in before David's or should we do it the other way round? Regards, Volker