From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 9F7A23858D32; Sun, 12 Feb 2023 21:28:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F7A23858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1676237302; bh=9E58lgQO4DPXhh0Y9OEQfWFbZs1Px0cVc5A0LJ3FX/c=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=r7BFsLqy6CDBXnSjsmMHEeppERp6aMpa2qI3PYtzxper7oNkjMY4sHD7tTAhZoon6 qEnSglhCz6jLFmDmmICpneHDMf2moTNfDIYkUJPKcgj3uqN9niDzRTlQdtKNY63BXd iwZVGY4lEChEbRZpiqxdXId9TKvUULCetQHcveAUZqCjcDBmqUNbIDB0RU47qsMlca KyjT6Hame9KUI7jh5qNHSaIlET+Ny8U0WFklvf8kB88jUUxog1vx5x+tFuHGY5iM1r HnlNSqBckZs/j2UIVCIn7d2NhZb6p6AVeclzqUL7lJTv03odo9wXB9Jyv3S64KCVsa EAFkcoJbUaY/A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.251.1.163] ([79.251.1.163]) by web-mail.gmx.net (3c-app-gmx-bap35.server.lan [172.19.172.105]) (via HTTP); Sun, 12 Feb 2023 22:28:22 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: Rimvydas Jasinskas Cc: fortran , gcc-patches Subject: Re: Support for NOINLINE attribute Content-Type: text/plain; charset=UTF-8 Date: Sun, 12 Feb 2023 22:28:22 +0100 Importance: normal Sensitivity: Normal In-Reply-To: References: X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:cukNQ/OfB27FogOO4Hro/pLvo5rVAcz60HdS3o3XjeF0IrEQimWCmOxqkRPAgH6dUTvEq Nhi/3tcZMx2XUs/rDw1s9QBNU5b50YB/tWlyuz7fcBAjW8n3Q/XtAMIIJbF3RpHZ0RhvUws2hibd DhuTFEB06C2YFXmnfyXYWTtzmfzFuoCnFl13GsVxZn2kgZ9kpgIFrorJHTRNtpuLTU7jT2lnoCLA W383WARQBUSVNbrfLqRh/+QyJaJ4nX+G79AnXNvyxjte4rcjk4uehIRFC8I8y2XBGy3qr0G0+f9m UM= UI-OutboundReport: notjunk:1;M01:P0:dtPdB599ZLQ=;DqpRavDSwvu+Ls67Tdzydf7+6ia GHLnxYfianI3TN4rETjz59uTDACysVLsXf0mXH198Bvh5BssIpoLQ0epYgvllBf8J6sX8UNU5 0ouIpRotgSA5GI3TYYs5Vu/N6qQhLDnpW6glrLa5akR8Dei1sjtJjEaeUhLlTdaLPAB7MXbjb CNdMwSTQjLmIo0W5IpFcVZ4Qty/ISjKQwo9vqKDJlY0WG3uGrt3kFj3W0MqtpS7kF5Cdwym6J w8v1vtE8MEzCp9FkPXvj8TC3P6O3JL503fL80/Abx4GyOH80GdLy47jOWRMwt3vae9QxvzQj7 bX/K8ps/7Q7vU++1tCzmjDLJGp9WoHW2r34M9uHYeDAHqxgJxHXhNc6Kku3Q+5PVUlk9m5ZdE jbmG9LQ0/kO/VUeEaBhecnpujPW3++XpH6UzWDvNaHSo0vv5fFtFugVvycXJ56fgtECJ1usjx EcCsiptreORWCjXzTocfVqr1RMyCqhpd/Ct1EsqQVcZ9dSNkPyDTah1KrvFlRTFA54Jd2dEdW N93fzWkMboynKtjZItLOqY6hhrv1PkRIOmnCnQqF7a5rRgRUcIt4DWtEWiijusYEoBB109/1U AA86r5NaXT6B0LQ9UpOQP/oz83TyHQXreUqEu2WQxCU2UWEBaZgIDKEtG/b7VoNx/L8EFq3P8 ITaCpkfJuYIaoY6PUYH60kZQXK43RK+aWjQfcFv/Sa+6Qt2AelwJK22QaaOGFKaYswiutuGFm heQQZiqDRwIuna4dk8r+Cy56+MgUXl5Jt+vQzv7piHME8joY8vyvS4Rw8x5u0iuWY7mq8KtXc YhgXDoWIR4oYYhpRAaeWsapA== Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Rimvydas, > Gesendet: Sonntag, 12. Februar 2023 um 07:59 Uhr > Von: "Rimvydas Jasinskas" > An: "Harald Anlauf" > Cc: "fortran" > Betreff: Re: Support for NOINLINE attribute > > On Sat, Feb 11, 2023 at 11:26 PM Harald Anlauf wrote: > > I am also not a native speaker, like many others contributing, but let > > me quote the relevant orignal paragraph: > > > > "The @code{noreturn} keyword tells the compiler to assume that > > @code{fatal} cannot return. It can then optimize without regard to wh= at > > would happen if @code{fatal} ever did return. This makes slightly > > better code. More importantly, it helps avoid spurious warnings of > > uninitialized variables." > > > > My reading of this original paragraph differs very much from the > > intention I get from the shortened version. Would you please reread? > > > > > Same, from extend.texi, see gcc/testsuite/gfortran.dg/noreturn-3.f90 > > > It is about marking dead conditional branches, so that the compiler > > > can prove proper initialization (no -Wmaybe-uninitialized given). I= t > > > should behave the same as in C frontend. > > > > True. And that's the whole point (IMHO), not silencing the compiler. > Hmm both look the same to me, the silencing of false positive > diagnostics is already implied by spurious. To simplify I have > changed it in v2 to just: > "add a hint that a given function cannot return" documentation could > be expanded later. > > > But shouldn't we rather follow what the C family of compilers in the > > first place does for a particular target? Most relevant libraries > > for Fortran code are either C/C++ or Fortran anyway, including any > > of the common MPI implementations, so should we care about Ada? > I agree with you. I have removed SUPPORTS_WEAK check and fixed > indentation in v2. > > Regtested cleany on x86_64-pc-linux-gnu. > > Regards, > Rimvydas this version of the patch looks good to me, so it is basically OK to commit. There is one thing I cannot test, which is the handling of weak symbols on other platforms. A quick glance at the C testcases suggests that someone with access to either an NVPTX or MingGW target might tell whether that particular target should be excluded. So I'd like to wait for 24 hours for others to comment on this. I see that you've signed-off your patch. Do you have commit rights? Otherwise I'll commit for you. (I've CC'ed to gcc-patches@ for this purpose.) Thanks for the patch! Harald