From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 91D6E3894404; Fri, 20 Aug 2021 09:45:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91D6E3894404 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.81.56] ([93.207.81.56]) by web-mail.gmx.net (3c-app-gmx-bap31.server.lan [172.19.172.101]) (via HTTP); Fri, 20 Aug 2021 11:45:33 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: jakub@redhat.com Cc: "H.J. Lu" , Tobias Burnus , Harald Anlauf via Gcc-patches , fortran Subject: Aw: Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514 Content-Type: multipart/mixed; boundary=kenitram-f061dc57-b1a1-4cbc-ac1c-4a23dcf555f5 Date: Fri, 20 Aug 2021 11:45:33 +0200 Importance: normal Sensitivity: Normal In-Reply-To: <20210820091618.GB2380545@tucnak> References: <8d25c317-74fa-d8a2-724f-de6944fa602e@codesourcery.com> <20210820091618.GB2380545@tucnak> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:rk4aSCDCGCf0AXbhOWpuj+Ah7gJcqRnppslaK/n+v2CKZiWg9qoppdLkFNuwxWCvEZy9Z XqeYKs8iDjTVJR8Td1C4gE55dkaLUBCVRPxwhI8huSFjJuX+ZPKTNdDrpMqKHz5efm7r4zflZ3LL eVVmgsdvBDZztoZA5dZrGFVugZxg284oYIMh4bfaJDbGbfzi7r8JnCj/P0xgiLllALBhrISXKcuS Iby7tMZpTdRASeke3a+kYDtzZod/d44XIc8LhBODA6DcPkO1HPOIwdNZIG9kquInJkR3iDGIaQOa 3g= X-UI-Out-Filterresults: notjunk:1;V03:K0:YVszb6CuIqA=:RRMPgeQotrFOQE+SDCRwVB Y+tQQfNUZYvmvAqE0GFCvjM0Gs+wVQ1gS+vkXTlkbQotcETT9qR+Zcco9XnNY4Yfgncsu0F9L YYog9X2adDkqBMALi9Of0gSNzgP5nc/JJxEfI2lvEsoUpFTKVYMRyVfeuocyoO5uBzCjqFj4y etq1Gw1IQUCwJYZq9yBs+dv/P59HfgVfB9hW5aXwhCaClU4ydaFanYd8nzFhtrAaKV3PNzyTz yk1Pp81klmpveBwTgdO7YzEYUXMt/nSSeOsyDAZlne58P/tiYTg9AnYqCjuPTONLgV+iOh4OE 5tWU7srwRDEfFe7eOB5hs7LC8xfC2uYV/hmT/QQv07ufKlrP4Fr1ULgUdxFVSvTuh5mF4m6ae VEkcMdYc3PKl4aWKVA1vLj7d9BxewTod54u2yTIKKHiu2ewHlexpkrM1cX7t2pgHXDhi8Z/ql 3egP5WTbKFJDyK3L4MYX3eBTV4k68NHd8XeVj+rbJiL+M0B5ql4sUJVrwZ800HOKo4rmh97IQ X+vLDBMuK7oPsD8+FMzTrj0ofxvhDJlofkuG5U8i5Hdu7jbbBlHWtTGtzTeNvs1YYfXBk+rGq F85L7eNdUIIUkOT0qyRxuyhsKWC26VlR0f+Wl6xjwIgJGjUcaQQ/OwVQWdwYnXBY27AGsoCp9 bAxM8y8olaFu1W4nANRrwMK/24L40hQ57Y4OpAWdFKYNZrQ0IFilbPMVFNt/tX3+9P/dSF5Sg usPyu10MPeJLxhdpjSNjd3rGYeuH20kxJ2e4QAv1FRjLkEd80g+Nr4E2SA4Zv495z5YMImU6l qoslDR4h8ZE2RSkzZ1riMRR7DCxag== X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2021 09:45:42 -0000 --kenitram-f061dc57-b1a1-4cbc-ac1c-4a23dcf555f5 Content-Type: text/plain; charset=UTF-8 Hi Jakob, thanks for the detailed explanation! > The other much easier but uglier option is to use a temporary buffer: > char buffer[21]; > sprintf (buffer, HOST_WIDE_INT_PRINT_DEC, hwint_val); > gfc_error ("... %s ...", ... buffer ...); > This works, as it uses the host sprintf i.e. *printf family for which > HOST_WIDE_INT_PRINT_DEC macro is designed. The attached followup patch implements this. Can anybody affected by current HEAD confirm that this fixes bootstrap? Thanks, Harald --kenitram-f061dc57-b1a1-4cbc-ac1c-4a23dcf555f5 Content-Type: text/x-patch Content-Disposition: attachment; filename=pr100950-followup.patch Content-Transfer-Encoding: quoted-printable diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c index 492867e12cb..eaabbffca4d 100644 =2D-- a/gcc/fortran/simplify.c +++ b/gcc/fortran/simplify.c @@ -4552,11 +4552,12 @@ substring_has_constant_len (gfc_expr *e) if (istart <=3D iend) { + char buffer[21]; if (istart < 1) { - gfc_error ("Substring start index (" HOST_WIDE_INT_PRINT_DEC - ") at %L below 1", - istart, &ref->u.ss.start->where); + sprintf (buffer, HOST_WIDE_INT_PRINT_DEC, istart); + gfc_error ("Substring start index (%s) at %L below 1", + buffer, &ref->u.ss.start->where); return false; } @@ -4567,9 +4568,9 @@ substring_has_constant_len (gfc_expr *e) length =3D gfc_mpz_get_hwi (ref->u.ss.length->length->value.integer); if (iend > length) { - gfc_error ("Substring end index (" HOST_WIDE_INT_PRINT_DEC - ") at %L exceeds string length", - iend, &ref->u.ss.end->where); + sprintf (buffer, HOST_WIDE_INT_PRINT_DEC, iend); + gfc_error ("Substring end index (%s) at %L exceeds string length", + buffer, &ref->u.ss.end->where); return false; } length =3D iend - istart + 1; --kenitram-f061dc57-b1a1-4cbc-ac1c-4a23dcf555f5--