From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id AA74B3858D1E; Mon, 6 Feb 2023 20:10:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA74B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1675714239; bh=gw+WCgkrQQkTGTm9woM251oDXbHSO+easXaHQPuYhqU=; h=X-UI-Sender-Class:From:To:Subject:Date; b=WCm5bYNcw53BClDTn+rjZj+sTUFpKlqMkVt87PPLJYWEbcSQ4azHZvPEUBaeBsR+K Fk+IqTbgx5mumC8doSZp72pQQXCnrYm/pqSw7lZ0XN3Ve/JwLlKHzO1jwxC8L4xbrK w6CldwB8BBnoQYr6p6CqnJlm3h20z4BCZZyrn1L0bsP/6iZaLAB+evMbVk8MASC29m Y3IgeRhZSEcPwBfSNBFArJ/klogQZBMT+1fPr704Os/THhwMxLB0ld4SdLe+y2SD07 zo2H0j+C3hkqndNF3ITUdZBU+xoC2S5jMU8Dt0/3mBA1OOAtmZFrhKjoZanmRhAIi2 Fa60W+TPX7Hqw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.89.127] ([93.207.89.127]) by web-mail.gmx.net (3c-app-gmx-bap04.server.lan [172.19.172.74]) (via HTTP); Mon, 6 Feb 2023 21:10:38 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] Fortran: ASSOCIATE variables should not be TREE_STATIC [PR95107] Content-Type: multipart/mixed; boundary=kenitram-f25d8429-e682-484a-af87-ed9df5415ce6 Date: Mon, 6 Feb 2023 21:10:38 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:dLBsDlbC6N4QegSUhu/ZU9XCPZwBsQOhU8V60wEVqd4FmOqaXcc/UKP14QzHYN2rZQnTb vUzTc9UJZqjS4B/rYzNBj2CEFLxynnB1oLN3tM3ti6orr54qDRQa2xo7BvjfyB9xvpJN7MNaEq7r 69KN10l7hobwZ+WPnTVn/mGq3tkDSq/XFxBjtWg70S5ITe+I98odW1cZ4JnM2f2O61989lKKjbsG GGSHWryRN2kptO1r2SnvR8Oa1x03ER8SXobp2HHfks+CFslolH3f1RNkZDuoCuSHJn+PmzvxOm21 NU= UI-OutboundReport: notjunk:1;M01:P0:F4aq8fo8//k=;RNZ7dVa8m6LOEiFfSzBkZlsUyYc lmRX1KflJFiyWvPySCgQm4XMgKDgjfbgDAezJ6zqo1Jo9kbBQzcLHieAR+lUDuaHakxvYMGym IJb9OzeWNi18gonNU3loDMhAU+42QLVJiVvwZBapR6D+JLD8JBvB4Dwpp+iJMwG7jbFYbNox+ oh8VMskmc2JNNeaIF8wBFm0am46b2cr1nrtkeCejd3p2VmeHZCh91SAgZmN0y9bgXDqy7Q75q Wnif96TQvpsdhAlUJKf2wGk5o8waEIWMVeumUvC+xGFyFPbNV9ZVLzcOKafFYxkTbNua+yV5Y i9gRpK/USnelAOTj0Xfw6kLyvGPdR6TjsWductc6y3JJcoeQA97mHb3b9yaCa/xjsYrvkD49g HIa0SayrjMKYUEvt3ycnevCmzT4tOzzLaCsbU/5vVvwa/wnJ52+RJaQI8vkx+WEocGceeHDpY I8nXwSgtcKZbNiMlnqlO8B1eM+Svyf+MHFnwr2U3zYR5OqjzlIB5nmtL7RyDczg0oSDh0bjQM tQqfKUfl7mkeeXh0ZH3H+UNxwoE2XUolXDZBYGtKrdqWi8cvdDOvtaq72y7FdOl++Ye01IwMW UEetsguXTyCkTLZV9K7w/I+WGQKo0ZcA32fRQT7962WwPq6E0eQH9+xEHyn+UA7cN7ovPqf8k v7LY9XxiK0s6WL4hzTIJj47LcN9FeveMLNoNhZ6iAf7vpPKFM6XuJszQpi7tzrEITbZdGb1OS L4WsIVONFgn50ZveXcYzU/cO/cfh98JWJrzHC67DRvMRMboAQQ41/w7aM19jOM8sdPOBLyS1P /IqFwteM58biu3Jrjde3WUHBgSd3L/g9S/LwTo27SAlOk= X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --kenitram-f25d8429-e682-484a-af87-ed9df5415ce6 Content-Type: text/plain; charset=UTF-8 Dear all, as the PR shows, it is likely not a good idea to try to make an ASSOCIATE variable static when -fno-automatic is specified, so rather keep it on the stack. Attached patch regtested on x86_64-pc-linux-gnu. OK for mainline? Thanks, Harald --kenitram-f25d8429-e682-484a-af87-ed9df5415ce6 Content-Type: text/x-patch Content-Disposition: attachment; filename=pr95107.diff Content-Transfer-Encoding: quoted-printable =46rom c29eb3dbe8c541ef83d5fdf12cafa015ed9447ee Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Mon, 6 Feb 2023 20:59:51 +0100 Subject: [PATCH] Fortran: ASSOCIATE variables should not be TREE_STATIC [PR95107] gcc/fortran/ChangeLog: PR fortran/95107 * trans-decl.cc (gfc_finish_var_decl): With -fno-automatic, do not make ASSOCIATE variables TREE_STATIC. gcc/testsuite/ChangeLog: PR fortran/95107 * gfortran.dg/save_7.f90: New test. =2D-- gcc/fortran/trans-decl.cc | 1 + gcc/testsuite/gfortran.dg/save_7.f90 | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/save_7.f90 diff --git a/gcc/fortran/trans-decl.cc b/gcc/fortran/trans-decl.cc index 7a077801919..f7a7ff607cd 100644 =2D-- a/gcc/fortran/trans-decl.cc +++ b/gcc/fortran/trans-decl.cc @@ -742,6 +742,7 @@ gfc_finish_var_decl (tree decl, gfc_symbol * sym) /* Keep variables larger than max-stack-var-size off stack. */ if (!(sym->ns->proc_name && sym->ns->proc_name->attr.recursive) && !sym->attr.automatic + && !sym->attr.associate_var && sym->attr.save !=3D SAVE_EXPLICIT && sym->attr.save !=3D SAVE_IMPLICIT && INTEGER_CST_P (DECL_SIZE_UNIT (decl)) diff --git a/gcc/testsuite/gfortran.dg/save_7.f90 b/gcc/testsuite/gfortran= .dg/save_7.f90 new file mode 100644 index 00000000000..dfbef12bec0 =2D-- /dev/null +++ b/gcc/testsuite/gfortran.dg/save_7.f90 @@ -0,0 +1,17 @@ +! { dg-do compile } +! { dg-options "-O2 -fno-automatic" } +! +! PR fortran/95107 - do not make associate variables TREE_STATIC +! Contributed by G.Steinmetz + +program p + type t + real, pointer :: a =3D> null() + end type + type t2 + type(t) :: b(1) + end type + type(t2), save :: x + associate (y =3D> x%b) + end associate +end =2D- 2.35.3 --kenitram-f25d8429-e682-484a-af87-ed9df5415ce6--