From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id B48213858D35; Tue, 21 Feb 2023 21:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B48213858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1677014647; i=anlauf@gmx.de; bh=lwjAXoBeUc/5UFHTIRxJGIC2IPHEfh6N32c4QI0knrU=; h=X-UI-Sender-Class:From:To:Subject:Date; b=WRCEOzEmvQFI9D5LbaO3opq1WkxlbqKvy1JPlEr9lUpC1KnFBB/UJfOWhh5njzbS2 EeHCehOOGfVd8Ok/5P6Pitd5TfgLgxyj9TzNdiuNqMkQ4TcqixzXTgTDgFurGVt1cz 7lh/8038vHbPlHfhPMMhag0fnvjDfAEGtoRcyn7KoAVSoQbchXjKKZHfKKtcc/SZQX aA8kBKmGpZCFUoaBvZ3220PYD9EPD90PyukIkTzkkxXAvyX1Uc9EHQo22StC2bQ5e+ t5WeXH6ZXOOa3Hju/yk+acQZFkTw377GC3WZr94lnQcMwKgX8JV1DzifUKZ0/eXCtF J6hFgmwN8Pmrg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.251.13.208] ([79.251.13.208]) by web-mail.gmx.net (3c-app-gmx-bs33.server.lan [172.19.170.85]) (via HTTP); Tue, 21 Feb 2023 22:18:58 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] Fortran: reject invalid CHARACTER length of derived type components [PR96024] Content-Type: multipart/mixed; boundary=sgnirk-7e5b295a-a95d-4ec5-92a9-01b100b1344c Date: Tue, 21 Feb 2023 22:18:58 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:3K7oFZa9dnTRaIPtR+Uy+CK5B13+Cz2T3rrTyd+eYPi5Vlp3ftqj3iRzNJXZSm4zW+Zpj 4QiFRn9U8ANZ1FlGGn1Etrc6eAVSfHkPuwV4hVAhMKeftc3+OcQ7Z9q8CUdTWXswy+gP30WaKm2P mbSUInRUuCIUMe+/9CBJ+B4Lo2Io3sDMNHenjivnu7FnLn1p0strlyfHy6l0Hy1NmGF6v3eDRKFL XAP/rxqMzRdwIE/8qQcR2G/YuWUGK0w/yAtU4ZZe4HZw4wdg858aOOdyBkN70pvgm+HtGv9v7d3W zg= UI-OutboundReport: notjunk:1;M01:P0:9y4bBcsFReA=;Wai11xYUSIKzE2zQiA/22kmhrHT 8tbp4tUxFhfJeRDiMsRsCtsMUOxRYH+CtwHm1wZWidpABP7Dpw8Nygk5Ab/I+BWpInA8EAzIu 0K8x9VjYZNhE73VPlxnUT/LHhb/K9vgTGMNCJFmIvVjz7YKux/HuN3bK+GGi995Zm+JiOLr77 9n7nWoXFHakrlN6oegUuAasBg21zA3UojCFSzce5h3Xj4I6s8EID0MBNbrDqFDYgKfXdGzX17 epbmXS+AlMTXxEepc9PyTOmklIfoDtr/WHkQHqJI8rts13sNQCW+HlpHKnIe1AMydZXljOBfN ZqiBipUIZUExb61uUxlhVuJ+Ak6cIBi4f/4kIOXBsan1NDREwtQlSot5Ng174stfSa6XtedBx ljF78wFroepX2FtrK5PUm25rAA/fP9BA1NObV3V/F4qzwNwck3G8Zs9r62PNiBZKxMwK0lp28 pnWdWFPhrMehF/vrbBz6FWVFzelpcQe6l08VOR2XUKN+HRmOFMHVsPh3Ai3GVbc+tNnue4uaU KL9IxsoStBpAnTOOHXxUih0Ni62VuWqdHryHFvQ/DY2haRXdA7/I1PubtkO8MfKDXLt5vRDkV r6D9OYYGiWzXypyuFPx6PENk69cSLz566hEPn877bHkSi8AKccXhVL22kxC3kF57DeFwFP8nH aM1w+HD8Nbrs81GCheFiuy7MX5HKbgPU4OnOo3kkZz/pgm1xq3y3RzSSWdSLXgNnBNzkH6wRY lQZ9h4FDFT1kxXGR/04V31k0s/VqXFec/A5fZwfptJ+1Z80fEgPTprOG3ySoszL6OqpEJe6JJ tTA8Du9dC0XD3yvltU878/3A== X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --sgnirk-7e5b295a-a95d-4ec5-92a9-01b100b1344c Content-Type: text/plain; charset=UTF-8 Dear all, the attached simple patch detects and rejects CHARACTER components of derived types whose length specification is non-integer. Regtested on x86_64-pc-linux-gnu. OK for mainline? This PR is also marked as a 10/11/12/13 regression, so I would like to backport this as far as it seems reasonable. Thanks, Harald --sgnirk-7e5b295a-a95d-4ec5-92a9-01b100b1344c Content-Type: text/x-patch Content-Disposition: attachment; filename=pr96024.diff Content-Transfer-Encoding: quoted-printable =46rom 0a392415cb5d5486e3e660880c81d6fdbbb47285 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Tue, 21 Feb 2023 22:06:33 +0100 Subject: [PATCH] Fortran: reject invalid CHARACTER length of derived type components [PR96024] gcc/fortran/ChangeLog: PR fortran/96024 * resolve.cc (resolve_component): The type of a CHARACTER length expression must be INTEGER. gcc/testsuite/ChangeLog: PR fortran/96024 * gfortran.dg/pr96024.f90: New test. =2D-- gcc/fortran/resolve.cc | 13 +++++++++++++ gcc/testsuite/gfortran.dg/pr96024.f90 | 11 +++++++++++ 2 files changed, 24 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pr96024.f90 diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 427f901a438..2780c82c798 100644 =2D-- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -14892,6 +14892,19 @@ resolve_component (gfc_component *c, gfc_symbol *= sym) c->ts.u.cl->length ? &c->ts.u.cl->length->where : &c-= >loc); return false; } + + if (c->ts.u.cl->length && c->ts.u.cl->length->ts.type !=3D BT_INTEGE= R) + { + if (!c->ts.u.cl->length->error) + { + gfc_error ("Character length expression of component %qs at %L " + "must be of INTEGER type, found %s", + c->name, &c->ts.u.cl->length->where, + gfc_basic_typename (c->ts.u.cl->length->ts.type)); + c->ts.u.cl->length->error =3D 1; + } + return false; + } } if (c->ts.type =3D=3D BT_CHARACTER && c->ts.deferred diff --git a/gcc/testsuite/gfortran.dg/pr96024.f90 b/gcc/testsuite/gfortra= n.dg/pr96024.f90 new file mode 100644 index 00000000000..2c914a997f2 =2D-- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr96024.f90 @@ -0,0 +1,11 @@ +! { dg-do compile } +! PR fortran/96024 - ICE in mio_name_expr_t +! Contributed by G.Steinmetz + +module m + implicit none + type t + character(char(1)) :: a ! { dg-error "must be of INTEGER type" } + end type + type(t) :: z =3D t('a') +end =2D- 2.35.3 --sgnirk-7e5b295a-a95d-4ec5-92a9-01b100b1344c--