* [PATCH] PR fortran/98284 - ICE in get_array_index
@ 2020-12-15 20:58 Harald Anlauf
2020-12-16 12:22 ` Thomas Koenig
0 siblings, 1 reply; 2+ messages in thread
From: Harald Anlauf @ 2020-12-15 20:58 UTC (permalink / raw)
To: fortran, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
Dear all,
ICE-on-invalid: testcase by Arseny, draft patch by Steve,
slightly polished and regtested by me on x86_64-pc-linux-gnu.
OK for master?
Thanks,
Harald
PR fortran/98284 - ICE in get_array_index
Reject DATA elements with the ALLOCATABLE attribute also when they are
components of a derived type.
gcc/fortran/ChangeLog:
PR fortran/98284
* resolve.c (check_data_variable): Reject DATA elements with the
ALLOCATABLE attribute.
gcc/testsuite/ChangeLog:
PR fortran/98284
* gfortran.dg/pr98284.f90: New test.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pr98284.patch --]
[-- Type: text/x-patch, Size: 1081 bytes --]
diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 327dffbebf2..05a5e43c90b 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -16169,6 +16169,13 @@ check_data_variable (gfc_data_variable *var, locus *where)
return false;
}
}
+
+ if (ref->type == REF_COMPONENT && ref->u.c.component->attr.allocatable)
+ {
+ gfc_error ("DATA element %qs at %L cannot have the ALLOCATABLE "
+ "attribute", ref->u.c.component->name, &e->where);
+ return false;
+ }
}
if (e->rank == 0 || has_pointer)
diff --git a/gcc/testsuite/gfortran.dg/pr98284.f90 b/gcc/testsuite/gfortran.dg/pr98284.f90
new file mode 100644
index 00000000000..aa4b95c667c
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr98284.f90
@@ -0,0 +1,12 @@
+! { dg-do compile }
+! PR fortran/98284 - ICE in get_array_index
+
+program p
+ implicit none
+ type t
+ integer, allocatable :: h(:)
+ end type t
+ type(t) :: u
+ integer :: i
+ data (u% h(i),i=1,8) /8*1/ ! { dg-error "cannot have the ALLOCATABLE attribute" }
+end
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PR fortran/98284 - ICE in get_array_index
2020-12-15 20:58 [PATCH] PR fortran/98284 - ICE in get_array_index Harald Anlauf
@ 2020-12-16 12:22 ` Thomas Koenig
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Koenig @ 2020-12-16 12:22 UTC (permalink / raw)
To: Harald Anlauf, fortran, gcc-patches
Hi Harald,
> ICE-on-invalid: testcase by Arseny, draft patch by Steve,
> slightly polished and regtested by me on x86_64-pc-linux-gnu.
OK for master.
Thanks for the patch!
Best regards
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-16 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 20:58 [PATCH] PR fortran/98284 - ICE in get_array_index Harald Anlauf
2020-12-16 12:22 ` Thomas Koenig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).