From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 6639A3857801; Fri, 15 Oct 2021 19:33:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6639A3857801 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.82.67] ([93.207.82.67]) by web-mail.gmx.net (3c-app-gmx-bs02.server.lan [172.19.170.51]) (via HTTP); Fri, 15 Oct 2021 21:33:47 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: Tobias Burnus Cc: fortran , gcc-patches Subject: Re: [PATCH] PR fortran/102685 - ICE in output_constructor_regular_field, at varasm.c:5514 Content-Type: text/plain; charset=UTF-8 Date: Fri, 15 Oct 2021 21:33:47 +0200 Importance: normal Sensitivity: Normal In-Reply-To: <178d8f79-0d99-9d21-6f02-381cb66be222@codesourcery.com> References: <178d8f79-0d99-9d21-6f02-381cb66be222@codesourcery.com> Content-Transfer-Encoding: quoted-printable X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:A7cN4P/8ZGygN4/yIfjpPW/ZLdrDYjhge4BVkX9NmvLsg5X7GzHRBR5nhMWmvNGY6JGAs Fp/TnJLpbyZ7Jm7Ar308Zqv7PL6Ryzos5jh/kRIHwCegPn5OEjsqPURbOkBOqMu6CSz+Hqknqlzf YzSiI/PDl1OtVQWexbn6cJZ2/VFJajt+At5SBdftq7z+JNBDlPMqephphJERvUCBPH2lxcDXima5 O43Kyl2WKLXAdokrU9gBWtxdbBjkGoq5Svd6vY0ELLvN2Mn3beMr+HZXoA6n3ijmmgJh0R1u2D4r 7E= X-UI-Out-Filterresults: notjunk:1;V03:K0:QcnhA2JFATc=:ptsdSBTvTVvLF+WSSc96KD 2aTHUPq1z/ktAChaOnR+nQfJ2/BXVfNGrE5kVg30SN/Nq4Wwrf/4epkLbD/NkRXP74Iue932F xnYaCuV7m9/wxLRfAy1tFQGXoPH/5fRKjd2Nx/ODTEmXNneyzINKRUVSU08o2GoN142rlAFRn VYNKK1Y6cyId3e3AQjwdMKYpzpk3rzAtN8EwKC4AWpurPnPJ8qZXuOe+kSiVDQuVSpkq5MDxD y6rehAoXTCdUQ1i8ofPn/txeY9hfKvy3NnXQmXQcWl4Ny5SVzDuShoj/5uEDHkbZ3WtK3wW37 3TqJzF3w3sjXH5Mrw2rsVes22mE4R7B9OVZCi/pVE7sILDcsUMxV2yqvoMHxqJsrozkm4yqVu Ufjpj08BG1UBZKo+jPXECX67DmC6agkXnWkLNQr40pyKD8vUlZp486UrthKt9hbXoc40OTgI9 TqA2ZGDxb3z/RXuTe9ajhDoZ9nKR85zE2Cta8imei7HIq/4bHhBFo8pkYJAcYnptYkWeAr7x9 Drip/80TGw33Jny5xkvBjUfvGBzoSUYznfQjsnlrnkLsrn4c1QobzHP5CJ+ob7Lk/W+jkrPnS dRUAXc8eCxyF0qyQP+1KLeUO1Bsur7g9yFGC/3iOcRa4cIfz3z25nxUGN+3LObMpCQdxXxavo dYJZWax+P8KNQzT1OWCz6BimfhTTYPJJDSpRUpIVqDvLNKvp5JCie/cxS2p1NYkwMLvnIPx9k Br8jKKRKaXMdI4HN9zz2jV0z/RmzN81kIufkP9KjMCCY5sAXA9VlNCeG1/0= X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Oct 2021 19:33:54 -0000 Hi Tobias, all, > > In developing the patch I encountered a difficulty with testcase > > dec_structure_6=2Ef90, which uses a DEC extension, namelist "old-style > > CLIST initializers in STRUCTURE"=2E I could not figure out how to > > determine the shape of the initializer; it seemed to be always zero=2E > > I've added code to accept this, but only under -fdec-structure, and > > added a TODO in a comment=2E If somebody reading this could give me > > a hint to solve end, I would adjust the patch accordingly=2E >=20 > See attached patch =E2=80=93 it does initialize the variables similarly = to other > shapes in that file, except that it has to take the shape from the LHS > as seemingly (same testfile) having a 1-dim array can be used to > initialize a 2-dim array=2E >=20 > You can approve that patch and integrate it then in your own patch :-) your fix to match_clist_expr LGTM=2E I can really use it=2E > LGTM =E2=80=93 with the DECL exception removed from resolve=2Ec=2E I've removed the DEC exception, cleaned up, regtested again=2E Committed and pushed: https://gcc=2Egnu=2Eorg/g:1e819bd95ebeefc1dc469daa1855ce005cb77822 Thanks, Harald > Thanks, >=20 > Tobias >=20 > PS: Without the auto-reshape part, a simple 'gfc_array_size (expr, > &expr->shape[0]))" would have been sufficient=2E > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe = 201, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 >