Re: [RFA:] Take 2

[Andreas Jaeger <aj@suse.de>]

Hans-Peter Nilsson <hp@bitrange.com> writes:

> On Tue, 19 Nov 2002, Andreas Jaeger wrote:
>> Hans-Peter Nilsson <hp@bitrange.com> writes:
>>
>> > On Tue, 19 Nov 2002, Andreas Jaeger wrote:
>> >
>> >> With valgrind from CVS, there's one problem with your patch:
>> >>
>> >> /cvs/gcc/gcc/cppfiles.c: In function `read_include_file':
>> >> /cvs/gcc/gcc/cppfiles.c:428: warning: implicit declaration of function `VALGRIND_DISCARD'
>> >
>> > Oh my, an API change.  I use 1.0.4 as you might guess.  I guess
>>
>> I used the latest CVS.
>
> The snapshot I see is stated to be "of the current development,
> unstable sources".  Perhaps they will change this before
> release, perhaps to something else.

I hope not - but who knows :-(

> (Where's the CVS repo?  Perhaps it says in the 1.1.0 ss.)

:pserver:anonymous@cvs.valgrind.sourceforge.net:/cvsroot/valgrind

>
>> > that's easily autoconf:ed for, if you please.
>>
>> Can you do that as part of your patch - if not, I'll try to do it next
>> weekend?
>
> Please do it.

Ok, will do.

>> Just checking for <memcheck.h> and including it if it exists should be
>> all that's needed,
>
> I think memcheck.h is just too common a name to do that without
> risking breakage (I hope they change that, perhaps to
> vgmemcheck.h).  I suggest checking whether VALGRIND_DISCARD is
> in valgrind.h, and if not, whether it's in memcheck.h and only
> *then* define some macro to test before including memcheck.h.
> I'll test with 1.0.4 if you do.  But I can't really test that it
> works for you with my current valgrind, so please do it.
> (FWIW, there's no memcheck.h in 1.0.4.)

I'll try to follow your suggestion,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj