From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14794 invoked by alias); 19 Nov 2002 17:15:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14784 invoked from network); 19 Nov 2002 17:15:15 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 19 Nov 2002 17:15:15 -0000 Received: from Hermes.suse.de (Charybdis.suse.de [213.95.15.201]) by Cantor.suse.de (Postfix) with ESMTP id BF8F214824; Tue, 19 Nov 2002 18:15:14 +0100 (MET) Received: from aj by arthur.inka.de with local (Exim 3.34 #1) id 18EBxx-0001ms-00; Tue, 19 Nov 2002 18:15:13 +0100 Mail-Copies-To: never To: Hans-Peter Nilsson Cc: Richard Henderson , , Julian Seward Subject: Re: [RFA:] Take 2 References: From: Andreas Jaeger Date: Tue, 19 Nov 2002 09:15:00 -0000 In-Reply-To: (Hans-Peter Nilsson's message of "Tue, 19 Nov 2002 12:07:21 -0500 (EST)") Message-ID: User-Agent: Gnus/5.090008 (Oort Gnus v0.08) XEmacs/21.4 (Artificial Intelligence, i386-suse-linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-11/txt/msg01134.txt.bz2 Hans-Peter Nilsson writes: > On Tue, 19 Nov 2002, Andreas Jaeger wrote: >> Hans-Peter Nilsson writes: >> >> > On Tue, 19 Nov 2002, Andreas Jaeger wrote: >> > >> >> With valgrind from CVS, there's one problem with your patch: >> >> >> >> /cvs/gcc/gcc/cppfiles.c: In function `read_include_file': >> >> /cvs/gcc/gcc/cppfiles.c:428: warning: implicit declaration of function `VALGRIND_DISCARD' >> > >> > Oh my, an API change. I use 1.0.4 as you might guess. I guess >> >> I used the latest CVS. > > The snapshot I see is stated to be "of the current development, > unstable sources". Perhaps they will change this before > release, perhaps to something else. I hope not - but who knows :-( > (Where's the CVS repo? Perhaps it says in the 1.1.0 ss.) :pserver:anonymous@cvs.valgrind.sourceforge.net:/cvsroot/valgrind > >> > that's easily autoconf:ed for, if you please. >> >> Can you do that as part of your patch - if not, I'll try to do it next >> weekend? > > Please do it. Ok, will do. >> Just checking for and including it if it exists should be >> all that's needed, > > I think memcheck.h is just too common a name to do that without > risking breakage (I hope they change that, perhaps to > vgmemcheck.h). I suggest checking whether VALGRIND_DISCARD is > in valgrind.h, and if not, whether it's in memcheck.h and only > *then* define some macro to test before including memcheck.h. > I'll test with 1.0.4 if you do. But I can't really test that it > works for you with my current valgrind, so please do it. > (FWIW, there's no memcheck.h in 1.0.4.) I'll try to follow your suggestion, Andreas -- Andreas Jaeger SuSE Labs aj@suse.de private aj@arthur.inka.de http://www.suse.de/~aj