From: Andreas Jaeger <aj@suse.de>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: Richard Henderson <rth@redhat.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [RFA:] Take 2 (was: Re: RFC: --enable-checking=valgrind.)
Date: Tue, 19 Nov 2002 07:31:00 -0000 [thread overview]
Message-ID: <u8ptt14lvy.fsf@gromit.moeb> (raw)
In-Reply-To: <Pine.BSF.4.44.0211190730320.14863-100000@dair.pair.com> (Hans-Peter Nilsson's message of "Tue, 19 Nov 2002 07:33:15 -0500 (EST)")
Hans-Peter Nilsson <hp@bitrange.com> writes:
> On Tue, 19 Nov 2002, Andreas Jaeger wrote:
>
>> With valgrind from CVS, there's one problem with your patch:
>>
>> /cvs/gcc/gcc/cppfiles.c: In function `read_include_file':
>> /cvs/gcc/gcc/cppfiles.c:428: warning: implicit declaration of function `VALGRIND_DISCARD'
>
> Oh my, an API change. I use 1.0.4 as you might guess. I guess
I used the latest CVS.
> that's easily autoconf:ed for, if you please.
Can you do that as part of your patch - if not, I'll try to do it next
weekend?
Just checking for <memcheck.h> and including it if it exists should be
all that's needed,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj
next prev parent reply other threads:[~2002-11-19 15:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-10 17:35 RFC: --enable-checking=valgrind Hans-Peter Nilsson
2002-11-10 19:34 ` Zack Weinberg
2002-11-11 1:55 ` Hans-Peter Nilsson
2002-11-11 16:53 ` Zack Weinberg
2002-11-11 17:48 ` Hans-Peter Nilsson
2002-11-12 6:02 ` Jan Hubicka
2002-11-12 17:11 ` Hans-Peter Nilsson
2002-11-12 17:21 ` Zack Weinberg
2002-11-13 5:32 ` Jan Hubicka
2002-11-13 13:38 ` Hans-Peter Nilsson
2002-11-18 17:20 ` Richard Henderson
2002-11-18 18:24 ` [RFA:] Take 2 (was: Re: RFC: --enable-checking=valgrind.) Hans-Peter Nilsson
2002-11-18 20:37 ` Richard Henderson
2002-11-20 11:57 ` Hans-Peter Nilsson
2002-11-18 22:12 ` Neil Booth
2002-11-19 4:37 ` Hans-Peter Nilsson
2002-11-18 22:33 ` Andreas Jaeger
2002-11-19 4:33 ` Hans-Peter Nilsson
2002-11-19 7:31 ` Andreas Jaeger [this message]
2002-11-19 9:07 ` Hans-Peter Nilsson
2002-11-19 9:15 ` [RFA:] Take 2 Andreas Jaeger
2002-11-26 5:42 ` [PATCH] Fix configure (was Re: [RFA:] Take 2 (was: Re: RFC: --enable-checking=valgrind.)) Jakub Jelinek
2002-11-26 9:59 ` Richard Henderson
2002-11-28 7:34 ` Hans-Peter Nilsson
2002-11-28 8:08 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u8ptt14lvy.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).